Skip to content

Commit c972d3f

Browse files
chore(deps-dev): bump @metamask/eslint-config from 14.1.0 to 15.0.0 (#854)
Bumps [@metamask/eslint-config](https://github.com/MetaMask/eslint-config) from 14.1.0 to 15.0.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/MetaMask/eslint-config/releases"><code>@​metamask/eslint-config</code>'s releases</a>.</em></p> <blockquote> <h2>15.0.0</h2> <h2><code>@​metamask/eslint-config</code> 15.0.0</h2> <h3>Changed</h3> <ul> <li><strong>BREAKING:</strong> Update <code>jsdoc/require-jsdoc</code> to require documentation for more things (<a href="https://github.com/MetaMask/eslint-config/pull/394">#394</a>) <ul> <li>New things that now require documentation are: <ul> <li>Arrow functions</li> <li>Class declarations</li> <li>TypeScript enum declarations</li> <li>Function expressions</li> <li>TypeScript interface declarations</li> <li>Method definitions</li> <li>TypeScript type alias declarations</li> <li>TypeScript property signatures</li> </ul> </li> </ul> </li> <li><strong>BREAKING:</strong> Convert various rules from <code>warn</code> to <code>error</code> (<a href="https://github.com/MetaMask/eslint-config/pull/424">#424</a>) <ul> <li>The rules impacted are: <ul> <li><code>promise/no-callback-in-promise</code></li> <li><code>promise/no-nesting</code></li> <li><code>promise/no-promise-in-callback</code></li> <li><code>promise/no-return-in-finally</code></li> <li><code>promise/valid-params</code></li> </ul> </li> </ul> </li> </ul> <h2><code>@​metamask/eslint-config-browser</code> 15.0.0</h2> <h3>Changed</h3> <ul> <li><strong>BREAKING:</strong> Bump peer dependency on <code>@metamask/eslint-config</code> from <code>^14.0.0</code> to <code>^15.0.0</code> (<a href="https://github.com/MetaMask/eslint-config/pull/431">#431</a>)</li> </ul> <h2><code>@​metamask/eslint-config-commonjs</code> 15.0.0</h2> <h3>Changed</h3> <ul> <li><strong>BREAKING:</strong> Bump peer dependency on <code>@metamask/eslint-config</code> from <code>^14.0.0</code> to <code>^15.0.0</code> (<a href="https://github.com/MetaMask/eslint-config/pull/431">#431</a>)</li> </ul> <h2><code>@​metamask/eslint-config-jest</code> 15.0.0</h2> <h3>Changed</h3> <ul> <li><strong>BREAKING:</strong> Bump peer dependency on <code>@metamask/eslint-config</code> from <code>^14.0.0</code> to <code>^15.0.0</code> (<a href="https://github.com/MetaMask/eslint-config/pull/431">#431</a>)</li> <li><strong>BREAKING:</strong> Convert various rules from <code>warn</code> to <code>error</code> (<a href="https://github.com/MetaMask/eslint-config/pull/424">#424</a>) <ul> <li>The rules impacted are: <ul> <li><code>jest/expect-expect</code></li> <li><code>jest/no-alias-methods</code></li> <li><code>jest/no-commented-out-tests</code></li> <li><code>jest/no-disabled-tests</code></li> </ul> </li> </ul> </li> <li>Widen <code>typescript</code> peer dependency to allow all 5.x versions (<a href="https://github.com/MetaMask/eslint-config/pull/422">#422</a>)</li> </ul> <h2><code>@​metamask/eslint-config-mocha</code> 15.0.0</h2> <h3>Changed</h3> <ul> <li><strong>BREAKING:</strong> Bump peer dependency on <code>@metamask/eslint-config</code> from <code>^14.0.0</code> to <code>^15.0.0</code> (<a href="https://github.com/MetaMask/eslint-config/pull/431">#431</a>)</li> </ul> <h2><code>@​metamask/eslint-config-nodejs</code> 15.0.0</h2> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/MetaMask/eslint-config/commit/0b8cf6db0edcc5e1582bf188a5495bfd6f1cf069"><code>0b8cf6d</code></a> Release/15.0.0 (<a href="https://github.com/MetaMask/eslint-config/issues/431">#431</a>)</li> <li><a href="https://github.com/MetaMask/eslint-config/commit/9568eb3707153dd06d1289a2609d274929e115c7"><code>9568eb3</code></a> fix: Disable <code>jsdoc/check-indentation</code> to fix bullet list formatting (<a href="https://github.com/MetaMask/eslint-config/issues/430">#430</a>)</li> <li><a href="https://github.com/MetaMask/eslint-config/commit/7837174f1d29fd4ee50173748009dac9b223d945"><code>7837174</code></a> feat: Loosen <code>@typescript-eslint/naming-convention</code> for object literal proper...</li> <li><a href="https://github.com/MetaMask/eslint-config/commit/cf93ef1cabcd65365a3401043a2ad2087b1e2a6a"><code>cf93ef1</code></a> fix: Disable <code>import-x/no-duplicates</code> in TypeScript files (<a href="https://github.com/MetaMask/eslint-config/issues/427">#427</a>)</li> <li><a href="https://github.com/MetaMask/eslint-config/commit/f3246f7ec2d4c206a0e8930765345339187d4a4e"><code>f3246f7</code></a> chore: Disable redudant lint rule (<a href="https://github.com/MetaMask/eslint-config/issues/425">#425</a>)</li> <li><a href="https://github.com/MetaMask/eslint-config/commit/383fbeca6ae261f1307d61ec99a16127b3f038a8"><code>383fbec</code></a> feat: Disable <code>@typescript-eslint/no-unnecessary-type-arguments</code> (<a href="https://github.com/MetaMask/eslint-config/issues/426">#426</a>)</li> <li><a href="https://github.com/MetaMask/eslint-config/commit/a0e0bc840a6d12f9dc2fb40be9f1022ffbff467e"><code>a0e0bc8</code></a> feat: Convert all warnings to errors (<a href="https://github.com/MetaMask/eslint-config/issues/424">#424</a>)</li> <li><a href="https://github.com/MetaMask/eslint-config/commit/b243e90e8923a784ace831cdf89e1a1aad6ffe27"><code>b243e90</code></a> chore: Increase minimum <code>typescript-eslint</code> version (<a href="https://github.com/MetaMask/eslint-config/issues/423">#423</a>)</li> <li><a href="https://github.com/MetaMask/eslint-config/commit/b1169747db159bd4fd537be78543e9dd81290ee0"><code>b116974</code></a> Allow remaining TypeScript 5.x versions (<a href="https://github.com/MetaMask/eslint-config/issues/422">#422</a>)</li> <li><a href="https://github.com/MetaMask/eslint-config/commit/c70a3ffb39a6f6a65f2dd15d73cdd72b739ffd7c"><code>c70a3ff</code></a> BREAKING: Update <code>jsdoc/require-jsdoc</code> to require documentation for more thin...</li> <li>Additional commits viewable in <a href="https://github.com/MetaMask/eslint-config/compare/@metamask/[email protected]...@metamask/[email protected]">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=@metamask/eslint-config&package-manager=npm_and_yarn&previous-version=14.1.0&new-version=15.0.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Upgrade ESLint config to v15 and adjust local lint rules by disabling stricter JSDoc checks to keep autofix stable. > > - **Dependencies**: > - Bump `@metamask/eslint-config` from `^14.1.0` to `^15.0.0` in `package.json` (lockfile updated). > - **ESLint configuration** (`eslint.config.mjs`): > - For Node/JS files and TypeScript overrides, disable `jsdoc/require-jsdoc` and `jsdoc/check-tag-names` to avoid autofix issues introduced by v15. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 61c59be. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> Co-authored-by: georgewrmarshall <[email protected]> Co-authored-by: George Marshall <[email protected]>
1 parent f87bd6f commit c972d3f

File tree

3 files changed

+17
-6
lines changed

3 files changed

+17
-6
lines changed

eslint.config.mjs

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,11 @@ const config = createConfig([
7777
rules: {
7878
// TODO: Re-enable this
7979
'n/no-sync': 'off',
80+
// TODO: Re-enable these rules. Enabling them with error suppression
81+
// breaks `--fix`, because the autofixer for these rules do not work very
82+
// well.
83+
'jsdoc/require-jsdoc': 'off',
84+
'jsdoc/check-tag-names': 'off',
8085
},
8186
},
8287
{
@@ -134,6 +139,12 @@ const config = createConfig([
134139
'no-restricted-globals': 'off',
135140
'@typescript-eslint/explicit-function-return-type': 'off',
136141

142+
// TODO: Re-enable these rules. Enabling them with error suppression
143+
// breaks `--fix`, because the autofixer for these rules do not work very
144+
// well.
145+
'jsdoc/require-jsdoc': 'off',
146+
'jsdoc/check-tag-names': 'off',
147+
137148
// Overrides eslint base config which isn't following outer most pattern. Can be removed once this issue is resolved and eslint config updated
138149
// issue: https://github.com/MetaMask/eslint-config/issues/403
139150
'import-x/order': [

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@
8585
"@figma/code-connect": "^1.0.0",
8686
"@lavamoat/allow-scripts": "^3.2.1",
8787
"@metamask/create-release-branch": "^4.1.3",
88-
"@metamask/eslint-config": "^14.1.0",
88+
"@metamask/eslint-config": "^15.0.0",
8989
"@metamask/eslint-config-jest": "^15.0.0",
9090
"@metamask/eslint-config-nodejs": "^15.0.0",
9191
"@metamask/eslint-config-typescript": "^15.0.0",

yarn.lock

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3363,9 +3363,9 @@ __metadata:
33633363
languageName: node
33643364
linkType: hard
33653365

3366-
"@metamask/eslint-config@npm:^14.1.0":
3367-
version: 14.1.0
3368-
resolution: "@metamask/eslint-config@npm:14.1.0"
3366+
"@metamask/eslint-config@npm:^15.0.0":
3367+
version: 15.0.0
3368+
resolution: "@metamask/eslint-config@npm:15.0.0"
33693369
dependencies:
33703370
"@eslint/js": "npm:^9.11.0"
33713371
globals: "npm:^15.9.0"
@@ -3377,7 +3377,7 @@ __metadata:
33773377
eslint-plugin-prettier: ^5.2.1
33783378
eslint-plugin-promise: ^7.1.0
33793379
prettier: ^3.3.3
3380-
checksum: 10/c6313391ea09130ae7254356069c8c28621d8dac668278291cba4436e95d4d5b8a43e11d7ce98ade96b2e4c7706171eba9c966ce7ba439fe888576bb32930b06
3380+
checksum: 10/93eb41bd61f3f4a0cf930a3d83e8893455f4f03339e91b21ef5a2835d24532db7c2916138a3e1b64777b5fb95cbe4ac90107697ac6f962c11ea7a99955cc75e4
33813381
languageName: node
33823382
linkType: hard
33833383

@@ -3401,7 +3401,7 @@ __metadata:
34013401
"@figma/code-connect": "npm:^1.0.0"
34023402
"@lavamoat/allow-scripts": "npm:^3.2.1"
34033403
"@metamask/create-release-branch": "npm:^4.1.3"
3404-
"@metamask/eslint-config": "npm:^14.1.0"
3404+
"@metamask/eslint-config": "npm:^15.0.0"
34053405
"@metamask/eslint-config-jest": "npm:^15.0.0"
34063406
"@metamask/eslint-config-nodejs": "npm:^15.0.0"
34073407
"@metamask/eslint-config-typescript": "npm:^15.0.0"

0 commit comments

Comments
 (0)