Open
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
✨ Files requiring CODEOWNER review ✨👨🔧 @MetaMask/core-extension-ux (2 files, +363 -184)
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
Builds ready [60aa3ac]
⚡ Performance Benchmarks (1453 ± 113 ms)
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚀 Bundle size reduced!]
|
Contributor
Builds ready [379bea7]
⚡ Performance Benchmarks (1379 ± 100 ms)
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚀 Bundle size reduced!]
|
Contributor
Builds ready [01d8379]
⚡ Performance Benchmarks (1384 ± 98 ms)
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
|
Contributor
Builds ready [6864aa7]
⚡ Performance Benchmarks (1425 ± 106 ms)
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update handling of mint/buy and send/receive NFT titles
Changelog
CHANGELOG entry: chore: update NFT transaction labels
Related issues
Fixes: #40319 and #40321
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
Changes user-visible transaction labeling logic based on heuristics over
valueTransfers, which could misclassify edge-case NFT transfers and affect UI consistency; scope is limited to titles/i18n/tests (no state or security changes).Overview
Updates Activity V2 transaction title generation to better classify NFT-related actions. A new
classifyNfthelper inspectsvalueTransfersto distinguish minted (from zero address), bought (incoming NFT plus outgoing native payment), received (incoming NFT without payment), and sent (outgoing NFT), and applies these labels for bothTRANSFERandCONTRACT_CALLcategories.Adds new i18n strings
nftBoughtandnftMinted, and significantly expandsuseGetTitlehook tests to cover the new NFT classification paths (including emptyvalueTransfers, OpenSea-style purchases, minting, gifting, and sender/receiver perspectives).Written by Cursor Bugbot for commit 6864aa7. This will update automatically on new commits. Configure here.