chore: remove activity log from transaction list item details#40380
Open
chore: remove activity log from transaction list item details#40380
Conversation
Co-authored-by: Francis Nepomuceno <n3ps@users.noreply.github.com>
n3ps
changed the title
Co-authored-by: Francis Nepomuceno <n3ps@users.noreply.github.com>
Contributor
Builds ready [7d31770]
⚡ Performance Benchmarks (1381 ± 94 ms)
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs
|
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Co-authored-by: Francis Nepomuceno <n3ps@users.noreply.github.com>
Co-authored-by: Francis Nepomuceno <n3ps@users.noreply.github.com>
|
Contributor
Builds ready [3f9f11b]
⚡ Performance Benchmarks (1380 ± 106 ms)
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚀 Bundle size reduced!]
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the Activity Log section from the transaction details modal rendered by
transaction-list-item-details.component.js.Reason: The Activity Log link/button in this modal has been broken for over a year and is unmaintained.
transaction-list-item-details.component.js.transaction-list-item-details/index.scss.Changelog
CHANGELOG entry: null
Related issues
Fixes: N/A (no issue number provided)
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Primarily removes unused UI and localization strings; risk is limited to potential missing i18n keys or any lingering imports/routes referencing the deleted
transaction-activity-logmodule.Overview
Removes the Transaction Activity Log UI from the transaction details modal, including deleting the entire
transaction-activity-logcomponent bundle (icon, container, utils, tests, snapshots) and dropping its SCSS import and related modal styling.Cleans up downstream dependencies by removing
activityLog/transaction-event i18n strings across locales, updatingtransaction-breakdown-utils.tsto useTransactionStatus.confirmedinstead of the removed constants, and simplifying bridge transaction-details navigation/state by no longer passing or rendering activity-log data.Written by Cursor Bugbot for commit 3f9f11b. This will update automatically on new commits. Configure here.