Open
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
n3ps
commented
Feb 24, 2026
| onClose: () => void; | ||
| }; | ||
|
|
||
| export const NonEvmDetailsModal = ({ transaction, onClose }: Props) => { |
Contributor
Author
There was a problem hiding this comment.
Thin wrapper over the multichain details modal
Contributor
✨ Files requiring CODEOWNER review ✨👨🔧 @MetaMask/core-extension-ux (3 files, +121 -2)
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
Builds ready [3f5490b]
⚡ Performance Benchmarks (1383 ± 113 ms)
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Contributor
Builds ready [eb1f84f]
⚡ Performance Benchmarks (1385 ± 108 ms)
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
|
Contributor
Builds ready [f04f27d]
⚡ Performance Benchmarks (1410 ± 105 ms)
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Render the correct modal for non-EVM bridge details
Changelog
CHANGELOG entry: fix: handle non-evm bridge details
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Small UI wiring change gated by existing bridge history data and
isCrossChainchecks; low risk outside of potentially showing the wrong modal if selectors/IDs don’t match.Overview
Fixes non-EVM Activity (v2) transaction details to show the bridge-specific details modal when the selected transaction matches bridge history and is cross-chain.
Introduces a
NonEvmDetailsModalwrapper that selects betweenMultichainBridgeTransactionDetailsModaland the genericMultichainTransactionDetailsModal, wires it intoactivity-list.tsx, and adds unit tests covering no-history, cross-chain, and same-chain (swap) cases.Written by Cursor Bugbot for commit f04f27d. This will update automatically on new commits. Configure here.