Skip to content

fix(deps): unpin [email protected],x [email protected] #11972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Mar 13, 2025
Merged

fix(deps): unpin [email protected],x [email protected] #11972

merged 22 commits into from
Mar 13, 2025

Conversation

@legobeat
Copy link
Contributor

@legobeat legobeat commented Oct 23, 2024 •
edited
Loading

Description

  • Unpin and dedupe ethereumjs-util and ethereumjs-abi while staying on legacy v6

  • Replace import { BN } from 'ethereumjs-util' with importing BN explicitly from either bn.js@4 or bn.js@5

    • Mixing the two is not safe and can cause breakage.
    • We don't get complete and correct typings with importing the old re-export
    • This adds both v4 and v5 as explicit dependencies - ideally v4 will be removed as transition to v5 concludes
    • Add EIP-1191 address checksum algorithm support for toChecksumAddress()
    • Unblock relying on the ancient and deprecated [email protected]

  • ethereumjs-util changelog

  • [email protected]

Related issues

Blocking

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@legobeat legobeat added dependencies Pull requests that update a dependency file team-application-security Application security team Run Smoke E2E and removed team-lavamoat labels Oct 23, 2024
@github-actions

This comment was marked as outdated.

Sign in to view
@socket-security
Copy link

socket-security bot commented Oct 23, 2024 •
edited
Loading

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@lavamoat/[email protected] ➜ 0.2.1 Transitive: environment, filesystem +6 2.56 MB
npm/@types/[email protected] None 0 0 B
npm/@types/[email protected] None 0 0 B
npm/[email protected] None 0 0 B
npm/[email protected] None 0 0 B
npm/[email protected] ➜ 0.6.8 None +2 214 kB holgerd77

🚮 Removed packages: npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

@github-actions

This comment was marked as outdated.

Sign in to view
@legobeat legobeat marked this pull request as ready for review October 23, 2024 10:41
@legobeat legobeat requested a review from a team as a code owner October 23, 2024 10:41
@legobeat legobeat requested a review from a team October 23, 2024 10:41
@legobeat legobeat requested a review from a team as a code owner October 23, 2024 10:41
legobeat
legobeat commented Oct 23, 2024
View reviewed changes
@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: b708bac
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/619aa4be-9711-4726-9e62-08968d39e035

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@legobeat legobeat marked this pull request as draft October 23, 2024 10:52
@legobeat legobeat force-pushed the deps-ethereumjs-6 branch 5 times, most recently from 6256e6b to 33737d5 Compare October 23, 2024 13:27
@github-actions

This comment was marked as outdated.

Sign in to view
@leotm leotm mentioned this pull request Mar 11, 2025
Merged
@metamaskbot

This comment was marked as outdated.

Sign in to view
@github-actions
Copy link
Contributor

github-actions bot commented Mar 12, 2025

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 9f3f322
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3bb3b0f3-47c9-4fd6-8408-704568d69485

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@metamaskbot
Copy link
Collaborator

metamaskbot commented Mar 12, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 9f3f322
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3bb3b0f3-47c9-4fd6-8408-704568d69485

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

wachunei
wachunei approved these changes Mar 12, 2025
View reviewed changes
Copy link
Member

@wachunei wachunei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ramp changes LGTM.

nickewansmith
nickewansmith approved these changes Mar 12, 2025
View reviewed changes
Copy link
Contributor

@nickewansmith nickewansmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stake changes lgtm

@NicolasMassart NicolasMassart self-requested a review March 13, 2025 10:12
salimtb
salimtb approved these changes Mar 13, 2025
View reviewed changes
Copy link
Contributor

@salimtb salimtb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assets changes LGTM

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 13, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
84.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

OGPoyraz
OGPoyraz approved these changes Mar 13, 2025
View reviewed changes
Copy link
Member

@OGPoyraz OGPoyraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmation changes LGTM

@NicolasMassart NicolasMassart added this pull request to the merge queue Mar 13, 2025
@github-project-automation github-project-automation bot moved this from Needs dev review to Review finalised - Ready to be merged in PR review queue Mar 13, 2025
Merged via the queue into main with commit 1fe6b9a Mar 13, 2025
39 checks passed
@NicolasMassart NicolasMassart deleted the deps-ethereumjs-6 branch March 13, 2025 11:24
@github-project-automation github-project-automation bot moved this from Review finalised - Ready to be merged to Merged, Closed or Archived in PR review queue Mar 13, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Mar 13, 2025
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Mar 13, 2025
@metamaskbot metamaskbot added the release-7.43.0 Issue or pull request that will be included in release 7.43.0 label Mar 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot Copilot left review comments

@wachunei wachunei wachunei approved these changes

@nickewansmith nickewansmith nickewansmith approved these changes

@NicolasMassart NicolasMassart NicolasMassart approved these changes

@OGPoyraz OGPoyraz OGPoyraz approved these changes

@Prithpal-Sooriya Prithpal-Sooriya Prithpal-Sooriya approved these changes

@salimtb salimtb salimtb approved these changes

@Cal-L Cal-L Awaiting requested review from Cal-L

@tommasini tommasini Awaiting requested review from tommasini

@sahar-fehri sahar-fehri Awaiting requested review from sahar-fehri

@lorenzosantos lorenzosantos Awaiting requested review from lorenzosantos

@pkowalski pkowalski Awaiting requested review from pkowalski

@klejeune klejeune Awaiting requested review from klejeune

@AxelGes AxelGes Awaiting requested review from AxelGes

@leotm leotm Awaiting requested review from leotm

@siibars siibars Awaiting requested review from siibars

@jpuri jpuri Awaiting requested review from jpuri

@digiwand digiwand Awaiting requested review from digiwand

@joaoloureirop joaoloureirop Awaiting requested review from joaoloureirop

@vinistevam vinistevam Awaiting requested review from vinistevam

@seaona seaona Awaiting requested review from seaona

@georgeweiler georgeweiler Awaiting requested review from georgeweiler

@pedronfigueiredo pedronfigueiredo Awaiting requested review from pedronfigueiredo

@matthewwalsh0 matthewwalsh0 Awaiting requested review from matthewwalsh0

Assignees

@NicolasMassart NicolasMassart

Labels

dependencies Pull requests that update a dependency file release-7.43.0 Issue or pull request that will be included in release 7.43.0 team-application-security Application security team team-mobile-platform Mobile Platform team team-ramp issues related to Ramp features

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.