-
Notifications
You must be signed in to change notification settings - Fork 844
remove MSI package and replace with app-local VSIX packages #4819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
10abc13
move compiler out of MSI and into a VSIX
brettfo 80e860c
move redistributable SDK out of MSI and into a VSIX
brettfo ceffd87
rename SWIX packages and remove unnecessary SDK resources package
brettfo f8897dd
use a more deterministic path for targets shims
brettfo 2e9e6da
remove unnecessary Update verb
brettfo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,14 +1,37 @@ | ||
| { | ||
| "sign": [ | ||
| { | ||
| "certificate": "VsixSHA2", | ||
| "strongName": null, | ||
| "values": [ | ||
| "insertion\\Microsoft.FSharp.SDK.Resources.ENU.vsix" | ||
| ] | ||
| } | ||
| ], | ||
| "exclude": [ | ||
| ] | ||
| } | ||
|
|
||
| "sign": [ | ||
| { | ||
| "certificate": "VsixSHA2", | ||
| "strongName": null, | ||
| "values": [ | ||
| "insertion\\Microsoft.FSharp.Compiler.vsix", | ||
| "insertion\\Microsoft.FSharp.Compiler.Resources.*.vsix", | ||
| "insertion\\Microsoft.FSharp.SDK.vsix" | ||
| ] | ||
| } | ||
| ], | ||
| "exclude": [ | ||
| "fsc.exe", | ||
| "FSharp.Build.dll", | ||
| "FSharp.Build.resources.dll", | ||
| "FSharp.Core.dll", | ||
| "FSharp.Core.resources.dll", | ||
| "FSharp.Compiler.Private.dll", | ||
| "FSharp.Compiler.Private.resources.dll", | ||
| "FSharp.Compiler.Server.Shared.dll", | ||
| "FSharp.Compiler.Interactive.Settings.dll", | ||
| "FSharp.Compiler.Interactive.Settings.resources.dll", | ||
| "fsi.exe", | ||
| "fsiAnyCpu.exe", | ||
| "FSharp.Data.TypeProviders.dll", | ||
| "Microsoft.Build.dll", | ||
| "Microsoft.Build.Conversion.Core.dll", | ||
| "Microsoft.Build.Engine.dll", | ||
| "Microsoft.Build.Framework.dll", | ||
| "Microsoft.Build.Tasks.Core.dll", | ||
| "Microsoft.Build.Utilities.Core.dll", | ||
| "System.Collections.Immutable.dll", | ||
| "System.Reflection.Metadata.dll", | ||
| "System.ValueTuple.dll" | ||
| ] | ||
| } | ||
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| net4*/ | ||
| netstandard*/ |
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are the above excluded - that doesn't seem right.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The listed files have either already been signed during this build (fsi, etc.) or come from a nuget package (microsoft.build.*).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can it be commented somehow so that people know why these are excluded?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sadly, no. The JSON file format specification doesn't allow comments as per RFC 7159.