Some refactoring on Lucy #17998
Open
Some refactoring on Lucy #17998
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glyh
commented
Oct 24, 2025
|
|
||
| let id { config; _ } = config.service_id | ||
|
|
||
| let infra_id { config; _ } = config.service_id |
glyh
force-pushed
the
lyh/integration-test-lib-refactor
branch
from
db76235 to
0e12723
Compare
glyh
force-pushed
the
lyh/integration-test-lib-refactor
branch
from
0e12723 to
ef9fa1b
Compare
This clarify the intention of this function.
…ed after the generator is closed
…rsistence implementation
glyh
force-pushed
the
lyh/integration-test-lib-refactor
branch
from
bff01eb to
c68241a
Compare
Member
Author
|
!ci-nightly-me |
Member
Author
Member
Author
|
Nightly passes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a bunch of noop refactoring, as I'm going through this system to understand what's going on.
TODO: rename
Node.{id -> infra_id}