refactor(animation): rename AnimationOnFinishOptions to AnimationCallbackOptions (ionic-team#19551)

Author: liamdebeasi

core/src/utils/animation/animation-interface.ts

@@ -210,7 +210,7 @@ export interface Animation {
    * Add a callback to be run
    * upon the animation ending
    */
-  onFinish(callback: AnimationLifecycle, opts?: AnimationOnFinishOptions): Animation;
+  onFinish(callback: AnimationLifecycle, opts?: AnimationCallbackOptions): Animation;
 
   /** @deprecated */
   playAsync(): Promise<void>;
@@ -220,7 +220,7 @@ export interface Animation {
 
 export type AnimationLifecycle = (currentStep: 0 | 1, animation: Animation) => void;
 
-export interface AnimationOnFinishOptions {
+export interface AnimationCallbackOptions {
   oneTimeCallback: boolean;
 }
 

core/src/utils/animation/animation.ts

@@ -2,12 +2,12 @@
 
 import { raf } from '../helpers';
 
-import { Animation, AnimationDirection, AnimationFill, AnimationKeyFrame, AnimationKeyFrames, AnimationLifecycle, AnimationOnFinishOptions, AnimationPlayOptions } from './animation-interface';
+import { Animation, AnimationCallbackOptions, AnimationDirection, AnimationFill, AnimationKeyFrame, AnimationKeyFrames, AnimationLifecycle, AnimationPlayOptions } from './animation-interface';
 import { addClassToArray, animationEnd, createKeyframeStylesheet, generateKeyframeName, generateKeyframeRules, removeStyleProperty, setStyleProperty } from './animation-utils';
 
 interface AnimationOnFinishCallback {
   c: AnimationLifecycle;
-  o?: AnimationOnFinishOptions;
+  o?: AnimationCallbackOptions;
 }
 
 interface AnimationInternal extends Animation {
@@ -101,7 +101,7 @@ export const createAnimation = (): Animation => {
     cleanUpStyleSheets();
   };
 
-  const onFinish = (callback: AnimationLifecycle, opts?: AnimationOnFinishOptions) => {
+  const onFinish = (callback: AnimationLifecycle, opts?: AnimationCallbackOptions) => {
     const callbacks = (opts && opts.oneTimeCallback) ? onFinishOneTimeCallbacks : onFinishCallbacks;
     callbacks.push({ c: callback, o: opts });