Skip to content

Commit 9c789b9

Browse files
fixed conditional expression in I2C_STOP_READING case
1 parent 25e5128 commit 9c789b9

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

examples/StandardFirmata/StandardFirmata.ino

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -383,7 +383,7 @@ void sysexCallback(byte command, byte argc, byte *argv)
383383
query[queryIndex].bytes = argv[4] + (argv[5] << 7);
384384
break;
385385
case I2C_STOP_READING:
386-
byte queryIndexToSkip;
386+
byte queryIndexToSkip;
387387
// if read continuous mode is enabled for only 1 i2c device, disable
388388
// read continuous reporting for that device
389389
if (queryIndex <= 0) {
@@ -393,7 +393,7 @@ void sysexCallback(byte command, byte argc, byte *argv)
393393
// determine which device to stop reading and remove it's data from
394394
// the array, shifiting other array data to fill the space
395395
for (byte i = 0; i < queryIndex + 1; i++) {
396-
if (query[i].addr = slaveAddress) {
396+
if (query[i].addr == slaveAddress) {
397397
queryIndexToSkip = i;
398398
break;
399399
}
@@ -496,9 +496,9 @@ void sysexCallback(byte command, byte argc, byte *argv)
496496
Firmata.write(pin);
497497
if (pin < TOTAL_PINS) {
498498
Firmata.write((byte)pinConfig[pin]);
499-
Firmata.write((byte)pinState[pin] & 0x7F);
500-
if (pinState[pin] & 0xFF80) Firmata.write((byte)(pinState[pin] >> 7) & 0x7F);
501-
if (pinState[pin] & 0xC000) Firmata.write((byte)(pinState[pin] >> 14) & 0x7F);
499+
Firmata.write((byte)pinState[pin] & 0x7F);
500+
if (pinState[pin] & 0xFF80) Firmata.write((byte)(pinState[pin] >> 7) & 0x7F);
501+
if (pinState[pin] & 0xC000) Firmata.write((byte)(pinState[pin] >> 14) & 0x7F);
502502
}
503503
Firmata.write(END_SYSEX);
504504
}
@@ -550,11 +550,11 @@ void systemResetCallback()
550550
// initialize a defalt state
551551
// TODO: option to load config from EEPROM instead of default
552552
if (isI2CEnabled) {
553-
disableI2CPins();
553+
disableI2CPins();
554554
}
555555
for (byte i=0; i < TOTAL_PORTS; i++) {
556556
reportPINs[i] = false; // by default, reporting off
557-
portConfigInputs[i] = 0; // until activated
557+
portConfigInputs[i] = 0; // until activated
558558
previousPINs[i] = 0;
559559
}
560560
// pins with analog capability default to analog input

0 commit comments

Comments
 (0)