Skip to content

Fix runtime lib loading logic #2297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Fix runtime lib loading logic #2297

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f5e8584
Fix ordering of runtime lib loading
ksivaman Oct 23, 2025
2c88485
Fix extension
ksivaman Oct 23, 2025
a2bd4bd
Merge branch 'main' into reorder_lib_loading
ksivaman Oct 24, 2025
56c0c73
Fixes
ksivaman Oct 28, 2025
454a9c9
Merge branch 'main' into reorder_lib_loading
ksivaman Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix extension 
Signed-off-by: Kirthi Shankar Sivamani <[email protected]>
  • Loading branch information
@ksivaman
ksivaman committed Oct 23, 2025
commit 2c88485be0d61caa367d50f1480c92ac08b924b6
10 changes: 5 additions & 5 deletions transformer_engine/common/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,11 +267,11 @@ def _load_cuda_library_from_python(lib_name: str):
# PyPI packages provided by nvidia libs exist
# in 3 possible direcories inside `nvidia`.
if os.path.isdir(os.path.join(nvidia_dir, "cu13")):
so_paths = glob.glob(os.path.join(nvidia_dir, "cu13", f"lib/lib*.{ext}.*[0-9]"))
so_paths = glob.glob(os.path.join(nvidia_dir, "cu13", f"lib/lib*{ext}.*[0-9]"))
if os.path.isdir(os.path.join(nvidia_dir, lib_name)):
so_paths = glob.glob(os.path.join(nvidia_dir, lib_name, f"lib/lib*.{ext}.*[0-9]"))
so_paths = glob.glob(os.path.join(nvidia_dir, lib_name, f"lib/lib*{ext}.*[0-9]"))
else:
so_paths = glob.glob(os.path.join(nvidia_dir, f"cuda_{lib_name}", f"lib/lib*.{ext}.*[0-9]"))
so_paths = glob.glob(os.path.join(nvidia_dir, f"cuda_{lib_name}", f"lib/lib*{ext}.*[0-9]"))

path_found = len(so_paths) > 0
ctypes_handles = []
Expand Down Expand Up @@ -303,14 +303,14 @@ def _load_cuda_library_from_system(lib_name: str):
for path in paths:
if path is None:
continue
libs = glob.glob(f"{path}/**/lib{lib_name}.{_get_sys_extension()}*", recursive=True)
libs = glob.glob(f"{path}/**/lib{lib_name}{_get_sys_extension()}*", recursive=True)
libs.sort(reverse=True, key=os.path.basename)
if libs:
return True, ctypes.CDLL(libs[0], mode=ctypes.RTLD_GLOBAL)

# Search in LD_LIBRARY_PATH.
try:
_lib_handle = ctypes.CDLL(f"lib{lib_name}.{_get_sys_extension()}", mode=ctypes.RTLD_GLOBAL)
_lib_handle = ctypes.CDLL(f"lib{lib_name}{_get_sys_extension()}", mode=ctypes.RTLD_GLOBAL)
return True, _lib_handle
except OSError:
return False, None
Expand Down
Loading