Fix for single and multiline comments

Author: amitguptagwl

bin/parser.js

@@ -43,6 +43,7 @@ var buildOptions = function (options){
 var getTraversalObj =function (xmlData,options){
     options = buildOptions(options);
     //xmlData = xmlData.replace(/>(\s+)/g, ">");//Remove spaces and make it single line.
+    xmlData = xmlData.replace(/<!--(.|\n)*?-->/g, "");//Remove single and multiline comments
     var tags = getAllMatches(xmlData,tagsRegx);
     var xmlObj = new xmlNode('!xml');
     var currentNode = xmlObj;

spec/cdata_spec.js

@@ -74,4 +74,43 @@ describe("XMLParser", function () {
         result = validator.validate(xmlData);
         expect(result).toBe(true);
     });
+
+    it("should ignore comment", function () {
+        var xmlData = "<rootNode><!-- <tag> - - --><tag>1</tag><tag>val</tag></rootNode>";
+
+        var expected = {
+                        "rootNode": {
+                            "tag": [1, "val"]
+                        }
+                    };
+
+        var result = parser.parse(xmlData, {
+            ignoreTextNodeAttr: false
+        });
+
+        expect(result).toEqual(expected);
+
+        var result = validator.validate(xmlData);
+        expect(result).toBe(true);
+    });
+
+    it("should ignore multiline comments", function () {
+        var xmlData = "<rootNode><!-- <tag> - - \n--><tag>1</tag><tag>val</tag></rootNode>";
+
+        var expected = {
+                        "rootNode": {
+                            "tag": [1, "val"]
+                        }
+                    };
+
+        var result = parser.parse(xmlData, {
+            ignoreTextNodeAttr: false
+        });
+
+        expect(result).toEqual(expected);
+
+        var result = validator.validate(xmlData);
+        expect(result).toBe(true);
+    });
+
 });

spec/validator_spec.js

@@ -120,6 +120,15 @@ describe("XMLParser", function () {
         expect(result).toBe(true);
     });
 
+
+    it("should validate xml with comment", function () {
+        var xmlData = "<rootNode><!-- <tag> - - \n--><tag>1</tag><tag>val</tag></rootNode>";
+
+        var result = validator.validate(xmlData);
+        expect(result).toBe(true);
+    });
+
+
     it("should not validate xml with comment in a open tag", function () {
         var xmlData = "<rootNode<!-- <tag> -- -->><tag>1</tag><tag>val</tag></rootNode>";