Skip to content

[image_picker]: Bump androidx.annotation:annotation from 1.3.0 to 1.6.0 in /packages/image_picker/image_picker_android/android #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dependabot wants to merge 16 commits into
base: main
Choose a base branch
from
Open

[image_picker]: Bump androidx.annotation:annotation from 1.3.0 to 1.6.0 in /packages/image_picker/image_picker_android/android #170

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
e872833
[path_provider]: Bump annotation
dependabot[bot] Sep 26, 2022
18bb963
unlock resolution
Sep 26, 2022
1b4e0d7
Merge commit 'e872833efb3b51e5e55f9b63ccf41c896b28bdb8'
Sep 26, 2022
012ae58
Merge branch 'flutter:main' into main
NeKoFu Oct 14, 2022
5adce68
Merge branch 'main' of [email protected]:NeKoFu/plugins.git
Jan 4, 2023
bb14e6e
Merge branch 'main' of [email protected]:NeKoFu/plugins.git
Jan 4, 2023
1b1d123
[camera]: reuse cameraId instead of the controller.cameraId to build …
Jan 4, 2023
abaff5a
[camera]: temporary patch to avoid camera init crash on android 13 ca…
Jan 5, 2023
3fdd4b3
[camera]: update compile sdk version to 33
Jan 5, 2023
edc6e79
[camera]: update compile sdk version to 33
Jan 5, 2023
ec4373d
[camera]: temporary patch configureResolution to avoid a crash on And…
Jan 5, 2023
3f13036
[camera]: add assert to catch bad function call on Android 13
Jan 5, 2023
5b8911a
Merge branch 'flutter:main' into main
NeKoFu Jan 5, 2023
a6ee2ec
[camera]: increment android version
Jan 5, 2023
bb86f93
[camera]: remove debug exception in resolution feature
Jan 5, 2023
ed04515
[image_picker]: Bump androidx.annotation:annotation
dependabot[bot] Feb 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[camera]: add assert to catch bad function call on Android 13
  • Loading branch information
David Roume committed Jan 5, 2023
commit 3f130369c2a9bf640eb8e46ce6457509a964c822
6 changes: 6 additions & 0 deletions ...ndroid/src/main/java/io/flutter/plugins/camera/features/resolution/ResolutionFeature.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,9 @@ static Size computeBestPreviewSize(int cameraId, ResolutionPreset preset)
// ! limiting the condition to Build.VERSION.SDK_INT == 31 && Build.VERSION.SDK_INT == 32 only
// ! to avoid crash on Android 13
if (Build.VERSION.SDK_INT >= 31 && Build.VERSION.SDK_INT < 33) {
throw new AssertionError(
"Calling function [ computeBestPreviewSize ] with SDK v" + Build.VERSION.SDK_INT + " and cameraId = " + cameraId);

EncoderProfiles profile =
getBestAvailableCamcorderProfileForResolutionPreset(cameraId, preset);
List<EncoderProfiles.VideoProfile> videoProfiles = profile.getVideoProfiles();
Expand Down Expand Up @@ -261,6 +264,9 @@ private void configureResolution(ResolutionPreset resolutionPreset, int cameraId
// ! limiting the condition to Build.VERSION.SDK_INT == 31 && Build.VERSION.SDK_INT == 32 only
// ! to avoid crash on Android 13
if (Build.VERSION.SDK_INT >= 31 && Build.VERSION.SDK_INT < 33) {
throw new AssertionError(
"Calling function [ configureResolution ] with SDK v" + Build.VERSION.SDK_INT + " and cameraId = " + cameraId);

recordingProfile =
getBestAvailableCamcorderProfileForResolutionPreset(cameraId, resolutionPreset);
List<EncoderProfiles.VideoProfile> videoProfiles = recordingProfile.getVideoProfiles();
Expand Down