Skip to content

Commit fe7e749

Browse files
authored
fix: Missing artwork ID in SWA My Collection flow (artsy#11045)
* fix: Missing artwork ID in SWA My Collection flow * test
1 parent 299521c commit fe7e749

File tree

2 files changed

+21
-3
lines changed

2 files changed

+21
-3
lines changed

src/app/Scenes/SellWithArtsy/ArtworkForm/Components/SubmitArtworkFromMyCollectionArtworks.tsx

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ import { SubmitArtworkStackNavigation } from "app/Scenes/SellWithArtsy/ArtworkFo
1111
import { fetchArtworkInformation } from "app/Scenes/SellWithArtsy/ArtworkForm/Utils/fetchArtworkInformation"
1212
import { getInitialSubmissionFormValuesFromArtwork } from "app/Scenes/SellWithArtsy/ArtworkForm/Utils/getInitialSubmissionValuesFromArtwork"
1313
import { SubmissionModel } from "app/Scenes/SellWithArtsy/ArtworkForm/Utils/validation"
14+
import { createOrUpdateSubmission } from "app/Scenes/SellWithArtsy/SubmitArtwork/ArtworkDetails/utils/createOrUpdateSubmission"
1415
import { dismissModal, switchTab } from "app/system/navigation/navigate"
1516
import { extractNodes } from "app/utils/extractNodes"
1617
import { useRefreshControl } from "app/utils/refreshHelpers"
@@ -48,17 +49,27 @@ export const SubmitArtworkFromMyCollectionArtworks: React.FC<{}> = () => {
4849
try {
4950
setIsLoading(true)
5051
// Fetch Artwork Details
52+
5153
const artwork = await fetchArtworkInformation(artworkID)
54+
5255
if (artwork) {
53-
const formValues = {
56+
const artworkValues = {
5457
...getInitialSubmissionFormValuesFromArtwork(artwork),
5558
submissionId: values.submissionId,
5659
externalId: values.externalId,
5760
userName: values.userName,
5861
userEmail: values.userEmail,
5962
userPhone: values.userPhone,
6063
}
61-
setValues(formValues)
64+
65+
const submission = await createOrUpdateSubmission(artworkValues, values.submissionId)
66+
67+
setValues({
68+
...artworkValues,
69+
submissionId: submission?.internalID || values.submissionId,
70+
externalId: submission?.externalID || values.externalId,
71+
})
72+
6273
setIsLoading(false)
6374

6475
navigation.navigate("AddTitle")

src/app/Scenes/SellWithArtsy/ArtworkForm/Components/__tests__/SubmitArtworkFromMyCollection.tests.tsx

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,17 @@ jest.mock("app/Scenes/SellWithArtsy/ArtworkForm/Utils/useSubmissionContext", ()
1212
}
1313
},
1414
}))
15-
1615
jest.mock("app/Scenes/SellWithArtsy/ArtworkForm/Utils/fetchArtworkInformation", () => ({
1716
fetchArtworkInformation: jest.fn().mockResolvedValue({ artwork: mockedFetchedArtwork }),
1817
}))
18+
jest.mock(
19+
"app/Scenes/SellWithArtsy/SubmitArtwork/ArtworkDetails/utils/createOrUpdateSubmission",
20+
() => ({
21+
createOrUpdateSubmission: jest
22+
.fn()
23+
.mockResolvedValue({ internalID: "internal-id", externalID: "external-id" }),
24+
})
25+
)
1926

2027
describe("SubmitArtworkFromMyCollection", () => {
2128
beforeEach(() => {

0 commit comments

Comments
 (0)