From 3299e7eaa5313aaf3ca7b4d48dfa40893a222527 Mon Sep 17 00:00:00 2001 From: felix Date: Thu, 15 Oct 2026 21:17:28 +0800 Subject: [PATCH] =?UTF-8?q?fix(runtime):=20=E4=BF=AE=E5=A4=8D=E7=A7=BB?= =?UTF-8?q?=E9=99=A4=E6=9C=AA=E6=B3=A8=E5=86=8C=E4=BA=8B=E4=BB=B6=E5=A4=84?= =?UTF-8?q?=E7=90=86=E5=99=A8=E6=97=B6=E8=AF=AF=E5=88=A0=E5=B7=B2=E6=9C=89?= =?UTF-8?q?=E7=9B=91=E5=90=AC=E5=99=A8?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- packages/taro-runtime/src/dom/event-target.ts | 4 ++ packages/taro-runtime/tests/event.spec.ts | 46 +++++++++++++++++++ 2 files changed, 50 insertions(+) diff --git a/packages/taro-runtime/src/dom/event-target.ts b/packages/taro-runtime/src/dom/event-target.ts index 4d28a4127f1e..62118077d384 100644 --- a/packages/taro-runtime/src/dom/event-target.ts +++ b/packages/taro-runtime/src/dom/event-target.ts @@ -81,6 +81,10 @@ export class TaroEventTarget { process.env.NODE_ENV !== 'production' && warn(index === -1, `事件: '${type}' 没有注册在 DOM 中,因此不会被移除。`) + if (index === -1) { + return + } + handlers.splice(index, 1) } diff --git a/packages/taro-runtime/tests/event.spec.ts b/packages/taro-runtime/tests/event.spec.ts index a1fcd8bf7c04..71ab2f813457 100644 --- a/packages/taro-runtime/tests/event.spec.ts +++ b/packages/taro-runtime/tests/event.spec.ts @@ -95,6 +95,52 @@ describe('event', () => { expect(spy2).toBeCalledTimes(2) }) + test.each([1, 2])('移除未注册的 handler 保留已有的 %i 个监听器', (count) => { + const view = document.createElement('view') + const listeners = Array.from({ length: count }, () => vi.fn()) + const unknown = vi.fn() + + for (const listener of listeners) { + view.addEventListener('tap', listener, null) + } + const handlers = view.__handlers.tap + const registered = handlers.slice() + const enqueueUpdate = vi.spyOn(view, 'enqueueUpdate') + + view.removeEventListener('tap', unknown) + view.dispatchEvent(runtime.createEvent('tap')) + + for (const listener of listeners) { + expect(listener).toHaveBeenCalledOnce() + } + expect(unknown).not.toHaveBeenCalled() + expect(view.__handlers.tap).toBe(handlers) + expect(handlers).toEqual(registered) + expect(enqueueUpdate).not.toHaveBeenCalled() + }) + + test('重复移除同一个 handler 保留其它监听器', () => { + const view = document.createElement('view') + const first = vi.fn() + const second = vi.fn() + + view.addEventListener('TaP', first, null) + view.addEventListener('tap', second, null) + view.removeEventListener('TAP', first) + view.removeEventListener('tap', first) + view.dispatchEvent(runtime.createEvent('tap')) + + expect(first).not.toHaveBeenCalled() + expect(second).toHaveBeenCalledOnce() + expect(view.__handlers.tap).toHaveLength(1) + + view.removeEventListener('tap', second) + view.dispatchEvent(runtime.createEvent('tap')) + + expect(second).toHaveBeenCalledOnce() + expect(view.__handlers.tap).toHaveLength(0) + }) + test('添加事件名会被小写化', () => { const div = document.createElement('div') const spy = vi.fn()