Skip to content

Synchronize to fix crashes in the user module #1554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 7, 2025
Merged

Synchronize to fix crashes in the user module #1554

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
acd3904
Add concurrency test
nan-li Apr 28, 2025
3106f4d
Add lock to OSModelStore models
nan-li Apr 21, 2025
d7cb25c
When sub ID is nullified, don't make server call
nan-li Apr 22, 2025
468b955
Synchronize the User Manager start up process
nan-li Apr 28, 2025
c348b3c
nits: simplify code
nan-li Apr 28, 2025
5fc5ca9
Add some additional checks and guards
nan-li Apr 28, 2025
735e755
update some user tests that now fail
nan-li Apr 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
update some user tests that now fail 
* Start the user manager before making updates for session time, purchases
  • Loading branch information
@nan-li
nan-li committed Apr 29, 2025
commit 735e7552409e41fb9e2d42481ec314441b28035e
3 changes: 3 additions & 0 deletions iOS_SDK/OneSignalSDK/OneSignalUserTests/OneSignalUserObjcTests.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,9 @@ - (void)testSendPurchases {

MockOneSignalClient* client = [MockOneSignalClient new];

// 0. Purchases will be dropped if there is no user instance.
[OneSignalUserManagerImpl.sharedInstance start];

// 1. Set up mock responses for the anonymous user
[MockUserRequests setDefaultCreateAnonUserResponsesWith:client];
[OneSignalCoreImpl setSharedClient:client];
Expand Down
2 changes: 2 additions & 0 deletions iOS_SDK/OneSignalSDK/OneSignalUserTests/OneSignalUserTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,8 @@ final class OneSignalUserTests: XCTestCase {
func testBasicCombiningUserUpdateDeltas_resultsInOneRequest() throws {
/* Setup */

OneSignalUserManagerImpl.sharedInstance.start()

let client = MockOneSignalClient()
MockUserRequests.setDefaultCreateAnonUserResponses(with: client)
OneSignalCoreImpl.setSharedClient(client)
Expand Down
Loading