updated the logo and paragraph #2
Conversation
|
✔️ Deploy Preview for modest-mestorf-a2c751 ready! 🔨 Explore the source changes: e04dad0 🔍 Inspect the deploy log: https://app.netlify.com/sites/modest-mestorf-a2c751/deploys/61f7ca5d7c7f94000711c05c 😎 Browse the preview: https://deploy-preview-2--modest-mestorf-a2c751.netlify.app/ |
| @@ -1,5 +1,5 @@ | |||
| import React from 'react' | |||
| import logo from '../src/assets/Ideaoryx.svg' | |||
| import logo from '../src/assets/Ideaoryx.png' | |||
There was a problem hiding this comment.
Is it possible for you to show the output for this for different viewports?
A screenshot would be cool, because I'm not sure if a png would scale as well as an svg for this case.
There was a problem hiding this comment.
okay i will change png to svg
dat-adi
left a comment
dat-adi
left a comment
There was a problem hiding this comment.
Changes with respect to the name change look good.
There are a few issues with the changes though.
- Check into whether the logo plays well with varying viewport sizes.
- Get rid of either
package-lock.jsonoryarn.lock, both of them together are unnecessary.
- updated the ideaoryx png logo to svg - changed project to projects in timeline file
SVijayB
left a comment
SVijayB
left a comment
There was a problem hiding this comment.
Changes have been reviewed. Everything looks good.
Approving for a merge.
@dat-adi