From 99779d17c45138dafc3fb7a80ef379960f51d782 Mon Sep 17 00:00:00 2001 From: "akihito.nakano" Date: Sun, 23 Dec 2018 11:48:20 +0900 Subject: [PATCH 1/3] Delete unused method --- .../codegen/CodegenModelFactory.java | 18 ------------------ 1 file changed, 18 deletions(-) diff --git a/modules/openapi-generator/src/main/java/org/openapitools/codegen/CodegenModelFactory.java b/modules/openapi-generator/src/main/java/org/openapitools/codegen/CodegenModelFactory.java index bd7c72d874d1..3ccfa052e061 100644 --- a/modules/openapi-generator/src/main/java/org/openapitools/codegen/CodegenModelFactory.java +++ b/modules/openapi-generator/src/main/java/org/openapitools/codegen/CodegenModelFactory.java @@ -25,24 +25,6 @@ public final class CodegenModelFactory { private static final Map> typeMapping = new HashMap>(); - /** - * Configure a different implementation class. - * - * @param type the type that shall be replaced - * @param implementation the implementation class must extend the default class and must provide a public no-arg constructor - */ - public static void setTypeMapping(CodegenModelType type, Class implementation) { - if (!type.getDefaultImplementation().isAssignableFrom(implementation)) { - throw new IllegalArgumentException(implementation.getSimpleName() + " doesn't extend " + type.getDefaultImplementation().getSimpleName()); - } - try { - implementation.getDeclaredConstructor().newInstance(); - } catch (Exception e) { - throw new IllegalArgumentException(e); - } - typeMapping.put(type, implementation); - } - @SuppressWarnings("unchecked") public static T newInstance(CodegenModelType type) { Class classType = typeMapping.get(type); From 72556fe3d311133eee53a4a8ffb1bb7a7fe8328f Mon Sep 17 00:00:00 2001 From: "akihito.nakano" Date: Sun, 23 Dec 2018 11:50:00 +0900 Subject: [PATCH 2/3] Delete unused property "typeMapping" --- .../java/org/openapitools/codegen/CodegenModelFactory.java | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/modules/openapi-generator/src/main/java/org/openapitools/codegen/CodegenModelFactory.java b/modules/openapi-generator/src/main/java/org/openapitools/codegen/CodegenModelFactory.java index 3ccfa052e061..521cad743b18 100644 --- a/modules/openapi-generator/src/main/java/org/openapitools/codegen/CodegenModelFactory.java +++ b/modules/openapi-generator/src/main/java/org/openapitools/codegen/CodegenModelFactory.java @@ -22,14 +22,10 @@ import java.util.Map; public final class CodegenModelFactory { - - private static final Map> typeMapping = new HashMap>(); - @SuppressWarnings("unchecked") public static T newInstance(CodegenModelType type) { - Class classType = typeMapping.get(type); try { - return (T) (classType != null ? classType : type.getDefaultImplementation()).getDeclaredConstructor().newInstance(); + return (T) type.getDefaultImplementation().getDeclaredConstructor().newInstance(); } catch (IllegalAccessException | InstantiationException | NoSuchMethodException | InvocationTargetException e) { throw new RuntimeException(e); } From 50d0055046f1a6079830af8fe2a0b1b86159fd62 Mon Sep 17 00:00:00 2001 From: "akihito.nakano" Date: Sun, 23 Dec 2018 11:50:54 +0900 Subject: [PATCH 3/3] Delete unused "import" declaration --- .../main/java/org/openapitools/codegen/CodegenModelFactory.java | 2 -- 1 file changed, 2 deletions(-) diff --git a/modules/openapi-generator/src/main/java/org/openapitools/codegen/CodegenModelFactory.java b/modules/openapi-generator/src/main/java/org/openapitools/codegen/CodegenModelFactory.java index 521cad743b18..e16c6bf25c1b 100644 --- a/modules/openapi-generator/src/main/java/org/openapitools/codegen/CodegenModelFactory.java +++ b/modules/openapi-generator/src/main/java/org/openapitools/codegen/CodegenModelFactory.java @@ -18,8 +18,6 @@ package org.openapitools.codegen; import java.lang.reflect.InvocationTargetException; -import java.util.HashMap; -import java.util.Map; public final class CodegenModelFactory { @SuppressWarnings("unchecked")