Approval events on transferFrom and burnFrom#1524
Merged
nventuro merged 3 commits intoOpenZeppelin:masterfrom Nov 29, 2018
Merged
Approval events on transferFrom and burnFrom#1524nventuro merged 3 commits intoOpenZeppelin:masterfrom
nventuro merged 3 commits intoOpenZeppelin:masterfrom
Conversation
nventuro
added
feature
Contributor
|
Yes I would add a comment in the code or in the inline docs or both. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this extension, an application should be able to just listen for
Approvalevents and still keep track of the allowances for all accounts.Should we add a comment in the code emphasizing the fact that the standard doesn't require the event to be emitted, and other compliant tokens may not do it?
Closes #707.