Merged
Conversation
nventuro
added
feature
Contributor
Author
|
Gah I forgot to update how the test helpers are used when updating the version. |
frangio
reviewed
Mar 13, 2019
frangio
reviewed
Mar 14, 2019
Co-Authored-By: nventuro <nicolas.venturo@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1676.
I only added the interface for the registry itself (the contract can be deployed in a testing environment using
openzeppelin-test-helpers), as well asIERC1820andERC1820, which are intended to be used by contracts that will be registered in the global registry.I chose those names to mimic the
ERC165naming scheme we already have (where a contract inherits fromERC165in order to indicate that it supports an interface, and contracts may cast addresses toIERC165to query support).It'd also be nice to provide some sort of way to get an instance of the global registry without having the user hardcode its address, e.g. some sort of factory that returns
IERC1820Registry(0x1820b744B33945482C17Dc37218C01D858EBc714).