Skip to content

Forward all gas on PullPayment withdrawal#1976

Merged
nventuro merged 9 commits intoOpenZeppelin:masterfrom
nventuro:pull-payment-full-gas
Oct 28, 2019
Merged

Forward all gas on PullPayment withdrawal#1976
nventuro merged 9 commits intoOpenZeppelin:masterfrom
nventuro:pull-payment-full-gas

Conversation

@nventuro
Copy link
Contributor

Fixes #1668.
Replaces #1714.

@nventuro nventuro added feature New contracts, functions, or helpers. contracts Smart contract code. labels Oct 28, 2019
@nventuro nventuro requested a review from frangio October 28, 2019 21:15
Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nventuro nventuro merged commit d6e10ab into OpenZeppelin:master Oct 28, 2019
@nventuro nventuro deleted the pull-payment-full-gas branch October 28, 2019 23:06
frangio pushed a commit that referenced this pull request Oct 29, 2019
* Add withdrawWithGas

* Improve docs

* Add changelog entry

* Update contracts/payment/PullPayment.sol

Co-Authored-By: Francisco Giordano <frangio.1@gmail.com>

* Remove repeated comment

* Update changelog entry

* Fix inline docs

* Fix changelog formatting

(cherry picked from commit d6e10ab)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contracts Smart contract code. feature New contracts, functions, or helpers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Have Escrow forward all gas to recipient

2 participants