Skip to content
Merged
Changes from 1 commit
Commits
Show all changes
50 commits
Select commit Hold shift + click to select a range
8378322
[Refactor] Replace optional reserveKey in PBF with unique pointer
random-zebra Apr 25, 2021
75c8c6d
Disallow copy of CReserveKeys
instagibbs Mar 3, 2017
0201065
Add COutput::fSafe member for safe handling of unconfirmed outputs
random-zebra Apr 25, 2021
f219be9
Add safe flag to listunspent result
NicolasDorier Feb 23, 2017
3a599d0
[Refactor] Return safeTx boolean in CheckTXAvailability
random-zebra May 28, 2021
3633d75
Initialize nRelockTime
pstratem Mar 14, 2017
60bb4da
ApproximateBestSubset should take inputs by reference, not value
RHavar Mar 28, 2017
7d977ac
Remove unused C++ code not covered by unit tests
random-zebra Apr 25, 2021
2394083
[Wallet] unset change position when there is no change on exact match
instagibbs Apr 28, 2017
494ba64
[test] Add test for getmemoryinfo
random-zebra Apr 25, 2021
54fa122
[qt] Move some WalletModel functions into CWallet
random-zebra Apr 28, 2021
e7cafab
[Refactoring] Mimic ListCoins for sapling notes
random-zebra Apr 28, 2021
5c3d73f
Avoid CWalletTx copies in GetAddressBalances and GetAddressGroupings
ryanofsky Jun 1, 2017
41a7335
Remove unused variables
practicalswift Jun 3, 2017
5bd1bd7
Properly forbid -salvagewallet and -zapwallettxes for multi wallet.
morcos Jul 13, 2017
7dd3916
Register wallet endpoint
jonasschnelli Jul 17, 2017
6cb2b92
Add wallet endpoint support to bitcoin-cli (-usewallet)
jonasschnelli Jul 13, 2017
b0fe92f
Fix test_pivx circular dependency issue
random-zebra Apr 28, 2021
5683a9c
Complete previous commit by moving mn stuff out of libbitcoin_wallet
random-zebra Apr 28, 2021
a64440b
Select wallet based on the given endpoint
jonasschnelli Jul 17, 2017
2e02006
Rename -usewallet to -rpcwallet
morcos Jul 19, 2017
f9141f8
[QA] Add wallet_multiwallet.py functional test
jnewbery Apr 28, 2021
808fbc3
[Bugfix] consider boolean value of -zapwallettxes ParameterInteraction
random-zebra Apr 28, 2021
379255e
[Tests][Trivial] Add wallet_multiwallet.py to test_runner
random-zebra Apr 28, 2021
9fb29cc
[Doc] Update multiwallet release notes
random-zebra Apr 28, 2021
a1c56fd
[Policy] Introduce -dustrelayfee
random-zebra Apr 28, 2021
cf4a90b
Remove factor of 3 from definition of dust.
random-zebra Apr 28, 2021
fdf5da0
[wallet] fix comment for CWallet::Verify()
jnewbery Jun 15, 2017
1525281
[wallet] [rpc] print wallet name in getwalletinfo
jnewbery Jun 15, 2017
4fd5913
[wallet] [rpc] Add listwallets RPC
jnewbery Jun 27, 2017
3955ee9
[Doc] Update release notes
random-zebra Apr 28, 2021
37089d1
[tests] Update wallet_multiwallet.py functional test
random-zebra Apr 28, 2021
ce35e1e
[Qt] Use wallet 0 in rpc console if running with multiple wallets
random-zebra Apr 28, 2021
ee52c2e
Fix misleading "Method not found" multiwallet errors
ryanofsky Jul 17, 2017
a1f4e2a
Reject duplicate wallet filenames
random-zebra Apr 28, 2021
900bbfa
Reject invalid wallet files
promag Jul 26, 2017
8bd979f
[wallet] Specify wallet name in wallet loading errors
random-zebra Apr 28, 2021
f49acf7
[wallet] [moveonly] Move CAffectedKeysVisitor
random-zebra Apr 28, 2021
2188c3e
Move some static functions out of wallet.h/cpp
random-zebra Apr 28, 2021
e947eec
MOVEONLY: Fee functions wallet/wallet.cpp -> wallet/fees.cpp
random-zebra Apr 28, 2021
e067235
MOVEONLY: Init functions wallet/wallet.cpp -> wallet/init.cpp
random-zebra Apr 28, 2021
ffcd781
[Trivial] Cleanup after MOVE-ONLY commits
random-zebra Apr 28, 2021
1d966ce
Add warnings field to getblockchaininfo
achow101 Jul 17, 2017
c04390b
Unify help text for GetWarnings output in get*info RPCs
random-zebra Apr 28, 2021
f15aeea
Change getmininginfo errors field to warnings
achow101 Sep 26, 2017
e411b70
[wallet] Fix leak in CDB constructor
promag Oct 12, 2017
20c269b
Avoid opening copied wallet databases simultaneously
ryanofsky Oct 10, 2017
dbda874
[Wallet] always show help-line of wallet encryption calls
jonasschnelli Nov 1, 2017
3711c6a
Add wallet backup text to import*, add* and dumpwallet RPCs
meshcollider Sep 8, 2017
d5526bd
Wrap dumpwallet warning and note scripts aren't dumped
meshcollider Oct 19, 2017
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[Doc] Update multiwallet release notes
  • Loading branch information
random-zebra committed Jun 2, 2021
commit 9fb29cc203aae2ec5d13649853c6cda032a9f09e
21 changes: 18 additions & 3 deletions doc/release-notes.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ Notable Changes

(Developers: add your notes here as part of your pull requests whenever possible)


Cold-Staking Re-Activation
--------------------------
PIVX Core v6.0.0 includes a fix for the vulnerability identified within the cold-staking protocol (see PR [#2258](https://github.com/PIVX-Project/PIVX/pull/2258)).
Expand All @@ -60,13 +61,22 @@ Scripts with the old opcode are still accepted on the network (the restriction o
Multi-wallet support
--------------------

PIVX Core now supports loading multiple, separate wallets (See [PR 2337](https://github.com/PIVX-Project/PIVX/pull/2337)). The wallets are completely separated, with individual balances, keys and received transactions.
PIVX Core now supports loading multiple, separate wallets (See [PR #2337](https://github.com/PIVX-Project/PIVX/pull/2337)). The wallets are completely separated, with individual balances, keys and received transactions.

Multi-wallet is enabled by using more than one `-wallet` argument when starting PIVX client, either on the command line or in the pivx.conf config file.

**In pivx-qt, only the first wallet will be displayed and accessible for creating and signing transactions.** GUI selectable multiple wallets will be supported in a future version. However, even in 6.0 other loaded wallets will remain synchronized to the node's current tip in the background.

!TODO: update after endpoint support and multi-wallet RPC support
PIVX Core 6.0.0 contains the following changes to the RPC interface and pivx-cli for multi-wallet:

* When running PIVX Core with a single wallet, there are **no** changes to the RPC interface or `pivx-cli`. All RPC calls and `pivx-cli` commands continue to work as before.
* When running PIVX Core with multi-wallet, all *node-level* RPC methods continue to work as before. HTTP RPC requests should be send to the normal `<RPC IP address>:<RPC port>` endpoint, and `pivx-cli` commands should be run as before. A *node-level* RPC method is any method which does not require access to the wallet.
* When running PIVX Core with multi-wallet, *wallet-level* RPC methods must specify the wallet for which they're intended in every request. HTTP RPC requests should be send to the `<RPC IP address>:<RPC port>/wallet/<wallet name>` endpoint, for example `127.0.0.1:8332/wallet/wallet1.dat`. `pivx-cli` commands should be run with a `-rpcwallet` option, for example `pivx-cli -rpcwallet=wallet1.dat getbalance`.

* A new *node-level* `listwallets` RPC method is added to display which wallets are currently loaded. The names returned by this method are the same as those used in the HTTP endpoint and for the `rpcwallet` argument.

Note that while multi-wallet is now fully supported, the RPC multi-wallet interface should be considered unstable for version 6.0.0, and there may backwards-incompatible changes in future versions.



GUI changes
Expand Down Expand Up @@ -125,13 +135,18 @@ A new init option flag '-blocksdir' will allow one to keep the blockfiles extern
Low-level RPC changes
---------------------

- The `listunspent` RPC now takes a `query_options` argument (see [PR 2317](https://github.com/PIVX-Project/PIVX/pull/2317)), which is a JSON object
- The `listunspent` RPC now takes a `query_options` argument (see [PR #2317](https://github.com/PIVX-Project/PIVX/pull/2317)), which is a JSON object
containing one or more of the following members:
- `minimumAmount` - a number specifying the minimum value of each UTXO
- `maximumAmount` - a number specifying the maximum value of each UTXO
- `maximumCount` - a number specifying the minimum number of UTXOs
- `minimumSumAmount` - a number specifying the minimum sum value of all UTXOs

- The `listunspent` RPC also takes an additional boolean argument `include_unsafe` (true by default) to optionally exclude "unsafe" utxos.
An unconfirmed output from outside keys is considered unsafe (see [PR #2351](https://github.com/PIVX-Project/PIVX/pull/2351)).

- The `listunspent` output also shows whether the utxo is considered safe to spend or not.

- the `stop` RPC no longer accepts the (already deprecated, ignored, and undocumented) optional boolean argument `detach`.


Expand Down