Merge pull request #2 from lutskanu/master

Basic type hintings, access modifiers and some phpcs warnings purification

Author: kbielenberg

src/Client.php

@@ -10,8 +10,13 @@ class Client implements ClientInterface
 {
     const DEFAULT_API_URL = 'https://fcm.googleapis.com/fcm/send';
 
+    /** @var string */
     private $apiKey;
+
+    /** @var string */
     private $proxyApiUrl;
+
+    /** @var GuzzleHttp\ClientInterface */
     private $guzzleClient;
 
     public function injectHttpClient(GuzzleHttp\ClientInterface $client)

src/ClientInterface.php

@@ -15,7 +15,7 @@ interface ClientInterface
      *
      * @return \paragraph1\phpFCM\Client
      */
-    function setApiKey($apiKey);
+    public function setApiKey($apiKey);
 
 
     /**
@@ -25,7 +25,7 @@ function setApiKey($apiKey);
      *
      * @return \paragraph1\phpFCM\Client
      */
-    function setProxyApiUrl($url);
+    public function setProxyApiUrl($url);
 
     /**
      * sends your notification to the google servers and returns a guzzle repsonse object
@@ -36,6 +36,6 @@ function setProxyApiUrl($url);
      * @return \Psr\Http\Message\ResponseInterface
      * @throws \GuzzleHttp\Exception\RequestException
      */
-    function send(Message $message);
+    public function send(Message $message);
 
 }

src/Message.php

@@ -30,6 +30,8 @@ class Message implements \JsonSerializable
      * where should the message go
      *
      * @param Recipient $recipient
+     * @throws \UnexpectedValueException
+     * @throws \InvalidArgumentException
      *
      * @return \paragraph1\phpFCM\Message
      */
@@ -133,7 +135,7 @@ function (Topic $topic) { return sprintf("'%s' in topics", $topic->getIdentifier
                 $jsonData['to'] = sprintf('/topics/%s', current($this->recipients)->getIdentifier());
                 break;
             default:
-                if (count($this->recipients) == 1) {
+                if (count($this->recipients) === 1) {
                     $jsonData['to'] = current($this->recipients)->getIdentifier();
                 }
         }

src/Recipient/Device.php

@@ -8,7 +8,6 @@ class Device implements Recipient
     public function __construct($token)
     {
         $this->token = $token;
-        return $this;
     }
 
     public function getIdentifier()

src/Recipient/Recipient.php

@@ -3,5 +3,5 @@
 
 interface Recipient
 {
-    function getIdentifier();
+    public function getIdentifier();
 }

src/Recipient/Topic.php

@@ -8,7 +8,6 @@ class Topic implements Recipient
     public function __construct($name)
     {
         $this->name = $name;
-        return $this;
     }
 
     public function getIdentifier()