chore: upgrade rrweb to alpha.17 #1488
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| + const rootDomain = window.location.origin | ||
| + const stylesheetPath = href.replace(window.location.href, '') | ||
| + const potentialStylesheetHref = rootDomain + '/' + stylesheetPath | ||
| + const rootDomain = window.location.origin; | ||
| + const stylesheetPath = href.replace(window.location.href, ''); | ||
| + const potentialStylesheetHref = rootDomain + '/' + stylesheetPath; |
There was a problem hiding this comment.
No real difference here, just added ; at the end of each line
|
Size Change: +1.57 MB (+54.38%) 🆘 Total Size: 4.46 MB
ℹ️ View Unchanged
|
holy cow
|
Nooooiceeee 😎 I'm not sure what's causing this. Here is the list of changes between 16 and 17: 
Perhaps all of postcss is being pulled in? It should only be needed during playback |
that's my first thought too |
pauldambra
left a comment
pauldambra
left a comment
There was a problem hiding this comment.
weeeellllll, do i approve this or not.
it's way tidier since we lose the patches
it works locally, which is the definitive test to prove all is well
the bundled file is waaaaayyyyy bigger which would be nice to avoid
|
yep @daibhin comparing v16 and v17 built output includes things like so pretty sure that postcss is being included |
|
but then the console recording plugin is as big as rrweb when looking at the bundle so, 🤷 |
|
Closing in favour of #1489 |
Changes
Following the big bump in #1276 which seems to have rolled out fine it is probably now worth moving to the latest version which has no scary changes.
Reapplied all patches
Best new feature is
dialogelement supportChecklist