This should fix issue 91 and I've add a argparse in order to specify … (prateekiiest#140)

* This should fix issue 91 and I've add a argparse in order to specify the data_filepath

* fix, a subset of, PEP8 issues

* fix, a subset of, PEP8 issues

* import module MUST be at the top

* import module MUST be at the top

* fixed 80 columns row

* removed useless import

* code refactored

* removed old code

* code refactored in order to avoid nested control flow statements

* avoid codebeat nested control

* eliminate codebeat nested control validation

* fix n arguments error on codeclimate

Author: Cereal84

Code-Sleep-Python/social_network/code.py

@@ -1,35 +1,47 @@
 import pandas as pd
-df  = pd.read_stata(data_filepath + "individual_characteristics.dta")
+from os import getcwd
+import argparse
+
+parser = argparse.ArgumentParser()
+parser.add_argument('-d', '--data_filepath', help="""Select the directory where
+                    is stored the file. Default is the current directory.""",
+                    default=getcwd())
+
+args = parser.parse_args()
+data_filepath = args.data_filepath
+
+df = pd.read_stata(data_filepath + "individual_characteristics.dta")
 df1 = df[df.village == 1]
 df2 = df[df.village == 2]
 
 # Enter code here!
 df1.head()
 
 
-sex1      = {df1.pid[i] : df1.resp_gend[i] for i in range(len(df1.pid))}
-caste1    = {df1.pid[i] : df1.caste[i] for i in range(len(df1.pid))}
-religion1 = {df1.pid[i] : df1.religion[i] for i in range(len(df1.pid))}
+def get_params(dfx, elem, items_range):
+    return {dfx.pid[i]: elem[i] for i in items_range}
+
+sex1 = get_params(df1, df1.resp_gend, range(len(df1.pid)))
+caste1 = get_params(df1,  df1.caste, range(len(df1.pid)))
+religion1 = (df1, df1.religion, range(len(df1.pid)))
+
 # Continue for df2 as well.
 
 j = 203
-sex2      = {df2.pid[j] : df2.resp_gend[j] for j in range(203,406)}
-caste2    = {df2.pid[j] : df2.caste[j] for j in range(203,406) }
-religion2 = {df2.pid[j] : df2.religion[j] for j in range(203,406)}
-
+sex2 = get_params(df2, df2.resp_gend, range(203, 406))
+caste2 = get_params(df2,  df2.caste, range(203, 406))
+religion2 = (df2, df2.religion, range(203, 406))
 
 
-from collections import Counter
 def chance_homophily(chars):
     # Enter code here!
     z = set(chars.values())
     su = 0
     for c in z:
-        
-        su = su + pow((sum(x == c for x in chars.values())/len(chars) * 1.0),2)
-    
+        su = su + pow((sum(x == c for x in chars.values())/len(chars) * 1), 2)
     return su
 
+
 favorite_colors = {
     "ankit":  "red",
     "xiaoyu": "blue",
@@ -40,7 +52,6 @@ def chance_homophily(chars):
 print(color_homophily)
 
 
-    
 print("Village 1 chance of same sex:", chance_homophily(sex1))
 # Enter your code here.
 print("Village 1 chance of same caste:", chance_homophily(caste1))
@@ -51,6 +62,31 @@ def chance_homophily(chars):
 print("Village 2 chance of same caste:", chance_homophily(caste2))
 
 
+def checks_for_homophility(nodes, G, chars, IDs):
+
+    num_ties = 0;
+    num_same_ties = 0;
+    n1 = nodes[0]
+    n2 = nodes[1]
+
+    if n1 <= n2:
+        return num_ties, num_same_ties
+
+    # do not double-count edges!
+    if (IDs[n1] in chars and IDs[n2] in chars) == False:
+        return num_ties, num_same_ties
+
+    if G.has_edge(n1, n2) == False:
+        return num_ties, num_same_ties
+
+    # Should `num_ties` be incremented?
+    # What about `num_same_ties`?
+    num_ties = 1
+    if chars[IDs[n1]] == chars[IDs[n2]]:
+        num_same_ties = 1
+
+    return num_ties, num_same_ties
+
 
 def homophily(G, chars, IDs):
     """
@@ -61,26 +97,25 @@ def homophily(G, chars, IDs):
     num_same_ties, num_ties = 0, 0
     for n1 in G.nodes():
         for n2 in G.nodes():
-            if n1 > n2:   # do not double-count edges!
-                if IDs[n1] in chars and IDs[n2] in chars:
-                    if G.has_edge(n1, n2):
-                        # Should `num_ties` be incremented?  What about `num_same_ties`?
-                        num_ties += 1
-                        if chars[IDs[n1]] == chars[IDs[n2]]:
 
+            nodes = [n1, n2]
+            ties, same_ties = check_for_homophily(nodes, G, chars, IDs)
 
-    return (num_same_ties / num_ties)
-    
-    
-print("Village 1 observed proportion of same sex:", homophily(G1, sex1, pid1))
-print("Village 1 observed proportion of same caste:", homophily(G1, caste1, pid1))
-print("Village 1 observed proportion of same religion:", homophily(G1, religion1, pid1))
-# Enter your code here!
-print("Village 2 observed proportion of same sex:", homophily(G2, sex2, pid2))
-print("Village 2 observed proportion of same caste:", homophily(G2, caste2, pid2))
-print("Village 2 observed proportion of same religion:", homophily(G1, religion2, pid2))
-
+            num_ties += ties
+            num_same_ties += same_ties
 
 
+    return (num_same_ties / num_ties)
 
 
+print("Village 1 observed proportion of same sex:", homophily(G1, sex1, pid1))
+print("Village 1 observed proportion of same caste:",
+      homophily(G1, caste1, pid1))
+print("Village 1 observed proportion of same religion:",
+      homophily(G1, religion1, pid1))
+# Enter your code here!
+print("Village 2 observed proportion of same sex:", homophily(G2, sex2, pid2))
+print("Village 2 observed proportion of same caste:",
+      homophily(G2, caste2, pid2))
+print("Village 2 observed proportion of same religion:",
+      homophily(G1, religion2, pid2))