improve ClientGameStateManager error logs (space-wizards#6452)

mastermiller01 · web-flow · commit 8404008c604c · 2026-03-15T16:42:12.000-04:00
* improve ClientGameStateManager error logs

* make it even better
diff --git a/Robust.Client/GameStates/ClientGameStateManager.cs b/Robust.Client/GameStates/ClientGameStateManager.cs
@@ -942,8 +942,7 @@ private void ApplyEntityStates(GameState curState, GameState? nextState)
                 }
                 catch (Exception e)
                 {
-                    _sawmill.Error($"Caught exception while updating entity broadphases");
-                    _runtimeLog.LogException(e, $"{nameof(ClientGameStateManager)}.{nameof(ApplyEntityStates)}");
+                    _runtimeLog.LogException(e, $"{nameof(ClientGameStateManager)}.{nameof(ApplyEntityStates)} caught exception while updating broadphase!");
                 }
             }
 
@@ -956,8 +955,7 @@ private void ApplyEntityStates(GameState curState, GameState? nextState)
                 }
                 catch (Exception e)
                 {
-                    _sawmill.Error($"Caught exception while deleting entities");
-                    _runtimeLog.LogException(e, $"{nameof(ClientGameStateManager)}.{nameof(ApplyEntityStates)}");
+                    _runtimeLog.LogException(e, $"{nameof(ClientGameStateManager)}.{nameof(ApplyEntityStates)} caught exception while deleting entities!");
 #if !EXCEPTION_TOLERANCE
                     throw;
 #endif

Original file line number	Diff line number	Diff line change
`@@ -942,8 +942,7 @@ private void ApplyEntityStates(GameState curState, GameState? nextState)`
`942`	`942`	`}`
`943`	`943`	`catch (Exception e)`
`944`	`944`	`{`
`945`		`- _sawmill.Error($"Caught exception while updating entity broadphases");`
`946`		`- _runtimeLog.LogException(e, $"{nameof(ClientGameStateManager)}.{nameof(ApplyEntityStates)}");`
	`945`	`+ _runtimeLog.LogException(e, $"{nameof(ClientGameStateManager)}.{nameof(ApplyEntityStates)} caught exception while updating broadphase!");`
`947`	`946`	`}`
`948`	`947`	`}`
`949`	`948`
`@@ -956,8 +955,7 @@ private void ApplyEntityStates(GameState curState, GameState? nextState)`
`956`	`955`	`}`
`957`	`956`	`catch (Exception e)`
`958`	`957`	`{`
`959`		`- _sawmill.Error($"Caught exception while deleting entities");`
`960`		`- _runtimeLog.LogException(e, $"{nameof(ClientGameStateManager)}.{nameof(ApplyEntityStates)}");`
	`958`	`+ _runtimeLog.LogException(e, $"{nameof(ClientGameStateManager)}.{nameof(ApplyEntityStates)} caught exception while deleting entities!");`
`961`	`959`	`#if !EXCEPTION_TOLERANCE`
`962`	`960`	`throw;`
`963`	`961`	`#endif`