fix(AppAPIService): encode query parameter arrays via http_build_query (nextcloud#412)

Resolves nextcloud#384. If the checks still pass and this gets merged, perhaps we
should take a look at other apps to see if they need to be updated in
the same way.

Signed-off-by: Edward Ly <[email protected]>
Co-authored-by: Alexander Piskun <[email protected]>

Author: edward-ly

lib/Service/AppAPIService.php

@@ -181,7 +181,7 @@ private function prepareRequestToExApp(
 
 		if ((!array_key_exists('multipart', $options)) && (count($params)) > 0) {
 			if ($method === 'GET') {
-				$url .= '?' . $this->getUriEncodedParams($params);
+				$url .= '?' . http_build_query($params);
 			} else {
 				$options['json'] = $params;
 			}
@@ -231,7 +231,7 @@ private function prepareRequestToExApp2(
 
 		if ((!array_key_exists('multipart', $options))) {
 			if (count($queryParams) > 0) {
-				$url .= '?' . $this->getUriEncodedParams($queryParams);
+				$url .= '?' . http_build_query($queryParams);
 			}
 			if ($method !== 'GET' && count($bodyParams) > 0) {
 				$options['json'] = $bodyParams;
@@ -258,19 +258,6 @@ private function swapAuthorizationHeader(array $headers): array {
 		return $headers;
 	}
 
-	private function getUriEncodedParams(array $params): string {
-		$paramsContent = '';
-		foreach ($params as $key => $value) {
-			if (is_array($value)) {
-				foreach ($value as $oneArrayValue) {
-					$paramsContent .= $key . '[]=' . urlencode($oneArrayValue) . '&';
-				}
-				unset($params[$key]);
-			}
-		}
-		return $paramsContent . http_build_query($params);
-	}
-
 	/**
 	 * AppAPI authentication request validation for Nextcloud:
 	 *  - checks if ExApp exists and is enabled