Link C libraries against build include folder #616
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug in the build system. The
lapackeandcblastargets include the source include folder instead of the build include folder. This means that any target downstream target that links against these usingtarget_link_librarieswon't get the correct include folder, which critically is missing the auto-generatedxxx_mangling.hheaders. This PR changes the build interface so that these targets now correctly use the${LAPACK_BINARY_DIR}/includedirectory.This arose from issue #614, which I was trying to build the lapack library after downloading it via
FetchContent, which is useful for bundling lapack together with source code rather than relying on a system installation.I'm not sure where/how to update the documentation for this change, but am happy to do so with some input from the maintainers.
Checklist