Skip to content

Commit 9b911d4

Browse files
aimensahnounaimensahnoun
committed
fix: fix typos and remove comments
1 parent 670523d commit 9b911d4

File tree

1 file changed

+2
-44
lines changed

1 file changed

+2
-44
lines changed

‎packages/transaction-manager/test/index.test.ts‎

Lines changed: 2 additions & 44 deletions
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,6 @@ describe('index', () => {
101101
const ret = await transactionManager.persistTransaction(data, channelId, extraTopics);
102102

103103
const resultConfirmed1 = await new Promise((resolve) => ret.on('confirmed', resolve));
104-
// 'result Confirmed wrong'
105104
expect(resultConfirmed1).toEqual({
106105
meta: {
107106
dataAccessMeta: { transactionStorageLocation: 'fakeDataId', topics: extraTopics },
@@ -110,9 +109,7 @@ describe('index', () => {
110109
result: {},
111110
});
112111

113-
// 'ret.result is wrong'
114112
expect(ret.result).toEqual({});
115-
// 'ret.meta is wrong'
116113
expect(ret.meta).toEqual({
117114
dataAccessMeta: fakeMetaDataAccessPersistReturn.meta,
118115
encryptionMethod: undefined,
@@ -133,9 +130,7 @@ describe('index', () => {
133130
TestData.idRaw3.encryptionParams,
134131
]);
135132

136-
// 'ret.result is wrong'
137133
expect(ret.result).toEqual({});
138-
// 'ret.meta is wrong'
139134
expect(ret.meta).toEqual({
140135
dataAccessMeta: fakeMetaDataAccessPersistReturn.meta,
141136
encryptionMethod: 'ecies-aes256-gcm',
@@ -162,13 +157,10 @@ describe('index', () => {
162157
const ret = await transactionManager.persistTransaction(data, channelId, extraTopics);
163158

164159
ret.on('error', (error) => {
165-
// 'result Confirmed wrong'
166160
expect(error).toBe('error for test purpose');
167161
});
168162

169-
// 'ret.result is wrong'
170163
expect(ret.result).toEqual({});
171-
// 'ret.meta is wrong'
172164
expect(ret.meta).toEqual({
173165
dataAccessMeta: fakeMetaDataAccessPersistReturn.meta,
174166
encryptionMethod: undefined,
@@ -181,7 +173,7 @@ describe('index', () => {
181173
});
182174
});
183175

184-
describe('in an existing new channel', () => {
176+
describe('in an existing channel', () => {
185177
afterEach(() => {
186178
jest.clearAllMocks();
187179
});
@@ -190,9 +182,7 @@ describe('index', () => {
190182

191183
const ret = await transactionManager.persistTransaction(data2, channelId, extraTopics);
192184

193-
// 'ret.result is wrong'
194185
expect(ret.result).toEqual({});
195-
// 'ret.meta is wrong'
196186
expect(ret.meta).toEqual({
197187
dataAccessMeta: fakeMetaDataAccessPersistReturn.meta,
198188
encryptionMethod: undefined,
@@ -243,9 +233,7 @@ describe('index', () => {
243233
);
244234
const ret = await transactionManager.persistTransaction(data2, channelId, extraTopics);
245235

246-
// 'ret.result is wrong'
247236
expect(ret.result).toEqual({});
248-
// 'ret.meta is wrong'
249237
expect(ret.meta).toEqual({
250238
dataAccessMeta: fakeMetaDataAccessPersistReturn.meta,
251239
encryptionMethod: 'ecies-aes256-gcm',
@@ -332,9 +320,7 @@ describe('index', () => {
332320
TestData.idRaw2.encryptionParams,
333321
]);
334322

335-
// 'ret.result is wrong'
336323
expect(ret.result).toEqual({});
337-
// 'ret.meta is wrong'
338324
expect(ret.meta).toEqual({
339325
dataAccessMeta: fakeMetaDataAccessPersistReturn.meta,
340326
encryptionMethod: 'ecies-aes256-gcm',
@@ -390,7 +376,7 @@ describe('index', () => {
390376
});
391377
});
392378

393-
describe('in an existing new channel', () => {
379+
describe('in an existing channel', () => {
394380
afterEach(() => {
395381
jest.clearAllMocks();
396382
});
@@ -400,7 +386,6 @@ describe('index', () => {
400386
const ret = await transactionManager.persistTransaction(data2, channelId, extraTopics);
401387

402388
expect(ret.result).toEqual({});
403-
// 'ret.meta is wrong'
404389
expect(ret.meta).toEqual({
405390
dataAccessMeta: { persisted: false },
406391
encryptionMethod: undefined,
@@ -520,9 +505,7 @@ describe('index', () => {
520505

521506
const ret = await transactionManager.getTransactionsByChannelId(channelId);
522507

523-
// 'ret.result is wrong'
524508
expect(ret.result).toEqual(fakeMetaDataAccessGetReturn.result);
525-
// 'ret.meta is wrong'
526509
expect(ret.meta).toEqual({
527510
dataAccessMeta: fakeMetaDataAccessGetReturn.meta,
528511
ignoredTransactions: [null, null],
@@ -558,7 +541,6 @@ describe('index', () => {
558541

559542
const ret = await transactionManager.getTransactionsByChannelId(channelId);
560543

561-
// 'ret.meta is wrong'
562544
expect(ret.meta).toEqual({
563545
dataAccessMeta: fakeMetaDataAccessGetReturnFirstHashWrong.meta,
564546
ignoredTransactions: [
@@ -571,7 +553,6 @@ describe('index', () => {
571553
],
572554
});
573555

574-
// 'ret.result is wrong'
575556
expect(ret.result).toEqual({
576557
transactions: [null, tx, tx2],
577558
});
@@ -606,7 +587,6 @@ describe('index', () => {
606587

607588
const ret = await transactionManager.getTransactionsByChannelId(channelId);
608589

609-
// 'ret.meta is wrong'
610590
expect(ret.meta).toEqual({
611591
dataAccessMeta: fakeMetaDataAccessGetReturnFirstHashWrong.meta,
612592
ignoredTransactions: [
@@ -619,7 +599,6 @@ describe('index', () => {
619599
],
620600
});
621601

622-
// 'ret.result is wrong'
623602
expect(ret.result).toEqual({
624603
transactions: [null, tx, tx2],
625604
});
@@ -664,7 +643,6 @@ describe('index', () => {
664643
);
665644
const ret = await transactionManager.getTransactionsByChannelId(channelId);
666645

667-
// 'return is wrong'
668646
expect(ret).toEqual({
669647
meta: {
670648
dataAccessMeta: { transactionsStorageLocation: ['fakeDataId1'] },
@@ -718,7 +696,6 @@ describe('index', () => {
718696
const transactionManager = new TransactionManager(fakeDataAccess);
719697
const ret = await transactionManager.getTransactionsByChannelId(channelId);
720698

721-
// 'return is wrong'
722699
expect(ret).toEqual({
723700
meta: {
724701
dataAccessMeta: { transactionsStorageLocation: ['fakeDataId1'] },
@@ -881,7 +858,6 @@ describe('index', () => {
881858
);
882859
const ret = await transactionManager.getTransactionsByChannelId(channelId);
883860

884-
// 'return is wrong'
885861
expect(ret).toEqual({
886862
meta: {
887863
dataAccessMeta: {
@@ -957,7 +933,6 @@ describe('index', () => {
957933
);
958934
const ret = await transactionManager.getTransactionsByChannelId(channelId);
959935

960-
// 'return is wrong'
961936
expect(ret).toEqual({
962937
meta: {
963938
dataAccessMeta: {
@@ -1036,7 +1011,6 @@ describe('index', () => {
10361011

10371012
const ret = await transactionManager.getTransactionsByChannelId(channelId);
10381013

1039-
// 'return is wrong'
10401014
expect(ret).toEqual({
10411015
meta: {
10421016
dataAccessMeta: {
@@ -1112,7 +1086,6 @@ describe('index', () => {
11121086
);
11131087
const ret = await transactionManager.getTransactionsByChannelId(channelId);
11141088

1115-
// 'return is wrong'
11161089
expect(ret).toEqual({
11171090
meta: {
11181091
dataAccessMeta: {
@@ -1260,7 +1233,6 @@ describe('index', () => {
12601233
);
12611234
const ret = await transactionManager.getTransactionsByChannelId(channelId);
12621235

1263-
// 'return is wrong'
12641236
expect(ret).toEqual(expectedRet);
12651237
});
12661238
});
@@ -1271,9 +1243,7 @@ describe('index', () => {
12711243

12721244
const ret = await transactionManager.getChannelsByTopic(extraTopics[0]);
12731245

1274-
// 'ret.result is wrong'
12751246
expect(ret.result).toEqual(fakeMetaDataAccessGetChannelsReturn.result);
1276-
// 'ret.meta is wrong'
12771247
expect(ret.meta).toEqual({
12781248
dataAccessMeta: fakeMetaDataAccessGetChannelsReturn.meta,
12791249
ignoredTransactions: {
@@ -1328,13 +1298,11 @@ describe('index', () => {
13281298

13291299
const ret = await transactionManager.getChannelsByTopic(extraTopics[0]);
13301300

1331-
// 'ret.result is wrong'
13321301
expect(ret.result).toEqual({
13331302
transactions: {
13341303
[channelId]: [tx],
13351304
},
13361305
});
1337-
// 'ret.meta is wrong'
13381306
expect(ret.meta).toEqual({
13391307
dataAccessMeta: fakeMetaDataAccessGetReturnWithEncryptedTransaction.meta,
13401308
ignoredTransactions: {
@@ -1386,13 +1354,11 @@ describe('index', () => {
13861354

13871355
const ret = await transactionManager.getChannelsByTopic(extraTopics[0]);
13881356

1389-
// 'ret.result is wrong'
13901357
expect(ret.result).toEqual({
13911358
transactions: {
13921359
[channelId]: [null],
13931360
},
13941361
});
1395-
// 'ret.meta is wrong'
13961362
expect(ret.meta).toEqual({
13971363
dataAccessMeta: fakeMetaDataAccessGetReturnWithEncryptedTransaction.meta,
13981364
ignoredTransactions: {
@@ -1458,7 +1424,6 @@ describe('index', () => {
14581424

14591425
const ret = await transactionManager.getChannelsByTopic(extraTopics[0]);
14601426

1461-
// 'ret.result is wrong'
14621427
expect(ret.result).toEqual({
14631428
transactions: {
14641429
[channelId]: [
@@ -1471,7 +1436,6 @@ describe('index', () => {
14711436
],
14721437
},
14731438
});
1474-
// 'ret.meta is wrong'
14751439
expect(ret.meta).toEqual({
14761440
dataAccessMeta: fakeMetaDataAccessGetReturnWithEncryptedTransaction.meta,
14771441
ignoredTransactions: {
@@ -1520,11 +1484,9 @@ describe('index', () => {
15201484

15211485
const ret = await transactionManager.getChannelsByTopic(extraTopics[0]);
15221486

1523-
// 'ret.result is wrong'
15241487
expect(ret.result).toEqual({
15251488
transactions: { [channelId]: [null, tx, tx2] },
15261489
});
1527-
// 'ret.meta is wrong'
15281490
expect(ret.meta).toEqual({
15291491
dataAccessMeta: fakeMetaDataAccessGetReturnFirstHashWrong.meta,
15301492
ignoredTransactions: {
@@ -1595,14 +1557,12 @@ describe('index', () => {
15951557

15961558
const ret = await transactionManager.getChannelsByTopic(extraTopics[0]);
15971559

1598-
// 'ret.result is wrong'
15991560
expect(ret.result).toEqual({
16001561
transactions: {
16011562
[channelId]: [tx],
16021563
[channelId2]: [tx2],
16031564
},
16041565
});
1605-
// 'ret.meta is wrong'
16061566
expect(ret.meta).toEqual({
16071567
dataAccessMeta: fakeMetaDataAccessGetReturnWithEncryptedTransaction.meta,
16081568
ignoredTransactions: {
@@ -1620,9 +1580,7 @@ describe('index', () => {
16201580

16211581
const ret = await transactionManager.getChannelsByMultipleTopics([extraTopics[0]]);
16221582

1623-
// 'ret.result is wrong'
16241583
expect(ret.result).toEqual(fakeMetaDataAccessGetChannelsReturn.result);
1625-
// 'ret.meta is wrong'
16261584
expect(ret.meta).toEqual({
16271585
dataAccessMeta: fakeMetaDataAccessGetChannelsReturn.meta,
16281586
ignoredTransactions: {

0 commit comments

Comments
 (0)