-
Notifications
You must be signed in to change notification settings - Fork 86
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: Rust-GPU/rust-gpu
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 84ed68fa96f8ef62f59b039e0133bbde227febe6
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: Rust-GPU/rust-gpu
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 5a773729302ae197fdd724cf2f3cbadeee77cab8
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 9 commits
- 30 files changed
- 3 contributors
Commits on Sep 17, 2025
-
Configuration menu - View commit details
-
Copy full SHA for 7e15027 - Browse repository at this point
Copy the full SHA 7e15027View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5b52374 - Browse repository at this point
Copy the full SHA 5b52374View commit details -
Configuration menu - View commit details
-
Copy full SHA for de03e8d - Browse repository at this point
Copy the full SHA de03e8dView commit details
Commits on Sep 18, 2025
-
Configuration menu - View commit details
-
Copy full SHA for ca2ea7b - Browse repository at this point
Copy the full SHA ca2ea7bView commit details -
It's supposed to produce a landscape with a small white sun, blue sky, and yellow ground. Instead it produces a small white sun and everything else is black. The problem is with the `sun_intensity_extra_spec_const_factor` argument to `sky_shader::fs`. - When running on the GPU, `sky_shader::fs` is called from `main_fs`, which has a spec_constant with a default value of 100. - When running on the CPU, `sky_shader::fs` is called directly from the CPU shader's `main`, and it passes 1. In other words, the CPU shader's sun intensity is 100x too small, which explains why it's so dark. This commit changes the value to 100, which makes the CPU shader produce the expected result. (The shader later divides the intensity value by 100. There are comments about integration testing for specialization constants that I don't understand.)
Configuration menu - View commit details
-
Copy full SHA for 19d23e5 - Browse repository at this point
Copy the full SHA 19d23e5View commit details
Commits on Sep 19, 2025
-
Configuration menu - View commit details
-
Copy full SHA for 8162296 - Browse repository at this point
Copy the full SHA 8162296View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9451cde - Browse repository at this point
Copy the full SHA 9451cdeView commit details -
Erase explicit layout decorations (
Offset/ArrayStride) when disal……lowed by Vulkan.
Configuration menu - View commit details
-
Copy full SHA for f05ba70 - Browse repository at this point
Copy the full SHA f05ba70View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5a77372 - Browse repository at this point
Copy the full SHA 5a77372View commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 84ed68fa96f8ef62f59b039e0133bbde227febe6...5a773729302ae197fdd724cf2f3cbadeee77cab8