Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: Rust-GPU/rust-gpu
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 84ed68fa96f8ef62f59b039e0133bbde227febe6
Choose a base ref
...
head repository: Rust-GPU/rust-gpu
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 5a773729302ae197fdd724cf2f3cbadeee77cab8
Choose a head ref
  • 9 commits
  • 30 files changed
  • 3 contributors

Commits on Sep 17, 2025

  1. Configuration menu
    Copy the full SHA
    7e15027 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5b52374 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    de03e8d View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2025

  1. Configuration menu
    Copy the full SHA
    ca2ea7b View commit details
    Browse the repository at this point in the history
  2. Fix the CPU sky-shader demo.

    It's supposed to produce a landscape with a small white sun, blue sky,
    and yellow ground. Instead it produces a small white sun and everything
    else is black. The problem is with the
    `sun_intensity_extra_spec_const_factor` argument to `sky_shader::fs`.
    
    - When running on the GPU, `sky_shader::fs` is called from `main_fs`,
      which has a spec_constant with a default value of 100.
    
    - When running on the CPU, `sky_shader::fs` is called directly from the
      CPU shader's `main`, and it passes 1.
    
    In other words, the CPU shader's sun intensity is 100x too small, which
    explains why it's so dark. This commit changes the value to 100, which
    makes the CPU shader produce the expected result.
    
    (The shader later divides the intensity value by 100. There are comments
    about integration testing for specialization constants that I don't
    understand.)
    nnethercote authored and Firestar99 committed Sep 18, 2025
    Configuration menu
    Copy the full SHA
    19d23e5 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2025

  1. Configuration menu
    Copy the full SHA
    8162296 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9451cde View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f05ba70 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    5a77372 View commit details
    Browse the repository at this point in the history
Loading