diff --git a/CHANGELOG.md b/CHANGELOG.md index 9d4756a..a6c6f76 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,12 @@ This project adheres to [Semantic Versioning](http://semver.org/). The format is based on [Keep a Changelog](http://keepachangelog.com/). +## 4.2.7 - 2024-06-27 + +### Fixed + + - Remove stacktrace from the message element of the log + ## 4.2.6 - 2024-02-26 ### Update diff --git a/sap/cf_logging/__init__.py b/sap/cf_logging/__init__.py index 6b5db7f..2a45bc9 100644 --- a/sap/cf_logging/__init__.py +++ b/sap/cf_logging/__init__.py @@ -10,7 +10,7 @@ from sap.cf_logging.record.request_log_record import RequestWebRecord from sap.cf_logging.record.simple_log_record import SimpleLogRecord -__version__ = '4.2.6' +__version__ = '4.2.7' _SETUP_DONE = False FRAMEWORK = None diff --git a/sap/cf_logging/record/simple_log_record.py b/sap/cf_logging/record/simple_log_record.py index 87accb4..af8f151 100644 --- a/sap/cf_logging/record/simple_log_record.py +++ b/sap/cf_logging/record/simple_log_record.py @@ -79,8 +79,6 @@ def format(self): stacktrace = ''.join(traceback.format_exception(*self.exc_info)) stacktrace = format_stacktrace(stacktrace) record['stacktrace'] = stacktrace.split('\n') - record['msg'] += "\n" - record['msg'] += stacktrace record.update(self.extra) diff --git a/tests/test_job_logging.py b/tests/test_job_logging.py index 6e22fc4..b7e1aec 100644 --- a/tests/test_job_logging.py +++ b/tests/test_job_logging.py @@ -68,7 +68,7 @@ def test_exception_stacktrace(): assert error == {} assert 'ZeroDivisionError' in str(log_json['stacktrace']) - assert 'ZeroDivisionError' in log_json["msg"] + assert log_json["msg"] == 'zero division error' def test_exception_stacktrace_info_level(): @@ -85,7 +85,7 @@ def test_exception_stacktrace_info_level(): assert error == {} assert 'ZeroDivisionError' in str(log_json['stacktrace']) - assert 'ZeroDivisionError' in log_json["msg"] + assert log_json["msg"] == 'zero division error' def test_custom_fields_set(): diff --git a/tests/unit/formatters/test_json_formatter.py b/tests/unit/formatters/test_json_formatter.py index 3144c99..56b3b8d 100644 --- a/tests/unit/formatters/test_json_formatter.py +++ b/tests/unit/formatters/test_json_formatter.py @@ -47,6 +47,4 @@ def test_stacktrace_is_added_to_msg_field(): record_object = json.loads(FORMATTER.format(log_record)) assert "Dummy Exception" in "".join(record_object["stacktrace"]) expected_msg = "Error found!" - expected_msg += "\n" - expected_msg += "\n".join(record_object["stacktrace"]) assert record_object["msg"] == expected_msg