Merge pull request #9 from dmglab/master

eliminated switch case in fieldDirective

Author: SelmanKahya

app/scripts/directives/field-directive.js

@@ -1,58 +1,50 @@
 'use strict';
 
-angularApp.directive('fieldDirective', function ($http, $compile) {
+// coffeescript's for in loop
+var __indexOf = [].indexOf || function(item) {
+        for (var i = 0, l = this.length; i < l; i++) {
+            if (i in this && this[i] === item) return i;
+        }
+        return -1;
+    };
 
-        var getTemplateUrl = function(field) {
-            var type = field.field_type;
-            var templateUrl = '';
+angularApp.directive('fieldDirective', function($http, $compile) {
 
-            switch(type) {
-                case 'textfield':
-                    templateUrl = './views/directive-templates/field/textfield.html';
-                    break;
-                case 'email':
-                    templateUrl = './views/directive-templates/field/email.html';
-                    break;
-                case 'textarea':
-                    templateUrl = './views/directive-templates/field/textarea.html';
-                    break;
-                case 'checkbox':
-                    templateUrl = './views/directive-templates/field/checkbox.html';
-                    break;
-                case 'date':
-                    templateUrl = './views/directive-templates/field/date.html';
-                    break;
-                case 'dropdown':
-                    templateUrl = './views/directive-templates/field/dropdown.html';
-                    break;
-                case 'hidden':
-                    templateUrl = './views/directive-templates/field/hidden.html';
-                    break;
-                case 'password':
-                    templateUrl = './views/directive-templates/field/password.html';
-                    break;
-                case 'radio':
-                    templateUrl = './views/directive-templates/field/radio.html';
-                    break;
-            }
-            return templateUrl;
-        }
+    var getTemplateUrl = function(field) {
+        var type = field.field_type;
+        var templateUrl = './views/directive-templates/field/';
+        var supported_fields = [
+            'textfield',
+            'email',
+            'textarea',
+            'checkbox',
+            'date',
+            'dropdown',
+            'hidden',
+            'password',
+            'radio'
+        ]
 
-        var linker = function(scope, element) {
-            // GET template content from path
-            var templateUrl = getTemplateUrl(scope.field);
-            $http.get(templateUrl).success(function(data) {
-                element.html(data);
-                $compile(element.contents())(scope);
-            });
+        if (__indexOf.call(supported_fields, type) >= 0) {
+            return templateUrl += type + '.html';
         }
+    }
+
+    var linker = function(scope, element) {
+        // GET template content from path
+        var templateUrl = getTemplateUrl(scope.field);
+        $http.get(templateUrl).success(function(data) {
+            element.html(data);
+            $compile(element.contents())(scope);
+        });
+    }
 
-        return {
-            template: '<div>{{field}}</div>',
-            restrict: 'E',
-            scope: {
-                field:'='
-            },
-            link: linker
-        };
-  });
+    return {
+        template: '<div>{{field}}</div>',
+        restrict: 'E',
+        scope: {
+            field: '='
+        },
+        link: linker
+    };
+});