Fix session Cookie creation to respect HostContext.Config.RestrictAllCookiesToDomain in .NET Core

Author: zigmo

src/ServiceStack/Host/Cookies.cs

@@ -15,12 +15,6 @@ public abstract class Cookies : ICookies
 
         public static Cookies CreateCookies(IHttpResponse httpRes)
         {
-#if NETSTANDARD1_6
-            if (httpRes?.OriginalResponse is Microsoft.AspNetCore.Http.HttpResponse)
-            {
-                return new NetCoreCookies(httpRes);
-            }
-#endif
             return new NetCookies(httpRes);
         }
 
@@ -80,53 +74,6 @@ public override void DeleteCookie(string cookieName)
         }
     }
 
-#if NETSTANDARD1_6
-    public class NetCoreCookies : Cookies
-    {
-        private readonly Microsoft.AspNetCore.Http.HttpResponse response;
-
-        public NetCoreCookies(IHttpResponse response)
-            : this((Microsoft.AspNetCore.Http.HttpResponse)response.OriginalResponse){}
-
-        public NetCoreCookies(Microsoft.AspNetCore.Http.HttpResponse response)
-        {
-            this.response = response;
-        }
-
-        public override void DeleteCookie(string cookieName)
-        {
-            response.Cookies.Delete(cookieName);
-        }
-
-        public override void AddPermanentCookie(string cookieName, string cookieValue, bool? secureOnly = null)
-        {
-            var options = new Microsoft.AspNetCore.Http.CookieOptions
-            {
-                Path = RootPath,
-                Expires = DateTime.UtcNow.AddYears(20)
-            };
-            if (secureOnly != null)
-            {
-                options.Secure = secureOnly.Value;
-            }
-            response.Cookies.Append(cookieName, cookieValue, options);
-        }
-
-        public override void AddSessionCookie(string cookieName, string cookieValue, bool? secureOnly = null)
-        {
-            var options = new Microsoft.AspNetCore.Http.CookieOptions
-            {
-                Path = RootPath,
-            };
-            if (secureOnly != null)
-            {
-                options.Secure = secureOnly.Value;
-            }
-            response.Cookies.Append(cookieName, cookieValue, options);
-        }
-    }
-#endif
-
     public static class CookiesExtensions
     {
         private static readonly DateTime Session = DateTime.MinValue;
@@ -159,7 +106,7 @@ public static CookieOptions ToCookieOptions(this Cookie cookie)
             var cookieOptions = new CookieOptions
             {
                 Path = cookie.Path,
-                Expires = cookie.Expires,
+                Expires = cookie.Expires == DateTime.MinValue ? (DateTimeOffset?)null : cookie.Expires,
                 HttpOnly = !HostContext.Config.AllowNonHttpOnlyCookies || cookie.HttpOnly,
                 Secure = cookie.Secure
             };