Skip to content

Commit 2f600da

Browse files
committed
fix: reduce Web UI version search down to 25
1 parent 2cdfe67 commit 2f600da

File tree

1 file changed

+28
-32
lines changed

1 file changed

+28
-32
lines changed

Shoko.Server/Services/WebUIUpdateService.cs

Lines changed: 28 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -256,43 +256,39 @@ public ComponentVersion GetLatestVersion(ReleaseChannel channel = ReleaseChannel
256256
// Check for dev channel updates.
257257
case ReleaseChannel.Dev:
258258
{
259-
const int MaxPages = 4;
260-
for (var page = 1; page <= MaxPages; page++)
259+
var releases = DownloadApiResponse("releases?per_page=25&page=1", ClientRepoName);
260+
foreach (var release in releases)
261261
{
262-
var releases = DownloadApiResponse($"releases?per_page=25&page={page}", ClientRepoName);
263-
foreach (var release in releases)
264-
{
265-
string tagName = release.tag_name;
266-
var version = tagName[0] == 'v' ? tagName[1..] : tagName;
267-
if (isNotDev && version.Contains("-dev"))
268-
continue;
262+
string tagName = release.tag_name;
263+
var version = tagName[0] == 'v' ? tagName[1..] : tagName;
264+
if (isNotDev && version.Contains("-dev"))
265+
continue;
269266

270-
string? description = release.body;
271-
var minServerVersion = GetMinimumServerVersion(description);
272-
if (!allowIncompatible && (minServerVersion is null || minServerVersion > currentServerVersion))
273-
continue;
267+
string? description = release.body;
268+
var minServerVersion = GetMinimumServerVersion(description);
269+
if (!allowIncompatible && (minServerVersion is null || minServerVersion > currentServerVersion))
270+
continue;
274271

275-
foreach (var asset in release.assets)
272+
foreach (var asset in release.assets)
273+
{
274+
// We don't care what the zip is named, only that it is attached.
275+
string fileName = asset.name;
276+
if (Path.GetExtension(fileName) is ".zip")
276277
{
277-
// We don't care what the zip is named, only that it is attached.
278-
string fileName = asset.name;
279-
if (Path.GetExtension(fileName) is ".zip")
278+
var tag = DownloadApiResponse($"git/ref/tags/{tagName}", ClientRepoName);
279+
string commit = tag["object"].sha;
280+
DateTime releaseDate = release.published_at;
281+
releaseDate = releaseDate.ToUniversalTime();
282+
return _cache.Set(key, new ComponentVersion
280283
{
281-
var tag = DownloadApiResponse($"git/ref/tags/{tagName}", ClientRepoName);
282-
string commit = tag["object"].sha;
283-
DateTime releaseDate = release.published_at;
284-
releaseDate = releaseDate.ToUniversalTime();
285-
return _cache.Set(key, new ComponentVersion
286-
{
287-
Version = version,
288-
MinimumServerVersion = minServerVersion,
289-
Commit = commit,
290-
ReleaseChannel = channel,
291-
ReleaseDate = releaseDate,
292-
Tag = tagName,
293-
Description = description?.Trim() ?? string.Empty,
294-
}, _cacheTTL);
295-
}
284+
Version = version,
285+
MinimumServerVersion = minServerVersion,
286+
Commit = commit,
287+
ReleaseChannel = channel,
288+
ReleaseDate = releaseDate,
289+
Tag = tagName,
290+
Description = description?.Trim() ?? string.Empty,
291+
}, _cacheTTL);
296292
}
297293
}
298294
}

0 commit comments

Comments
 (0)