RIP Trakt Scrobble

Author: harshithmohan

Shoko.Server/API/v0/Controllers/PlexWebhook.cs

@@ -18,7 +18,6 @@
 using Shoko.Server.Extensions;
 using Shoko.Server.Models;
 using Shoko.Server.Plex;
-using Shoko.Server.Providers.TraktTV;
 using Shoko.Server.Repositories;
 using Shoko.Server.Scheduling;
 using Shoko.Server.Scheduling.Jobs.Plex;
@@ -38,14 +37,12 @@ namespace Shoko.Server.API.v0.Controllers;
 public class PlexWebhook : BaseController
 {
     private readonly ILogger<PlexWebhook> _logger;
-    private readonly TraktTVHelper _traktHelper;
     private readonly ISchedulerFactory _schedulerFactory;
     private readonly IUserDataService _userDataService;
 
-    public PlexWebhook(ILogger<PlexWebhook> logger, TraktTVHelper traktHelper, ISettingsProvider settingsProvider, ISchedulerFactory schedulerFactory, IUserDataService userDataService) : base(settingsProvider)
+    public PlexWebhook(ILogger<PlexWebhook> logger, ISettingsProvider settingsProvider, ISchedulerFactory schedulerFactory, IUserDataService userDataService) : base(settingsProvider)
     {
         _logger = logger;
-        _traktHelper = traktHelper;
         _schedulerFactory = schedulerFactory;
         _userDataService = userDataService;
     }
@@ -64,47 +61,16 @@ public async Task<ActionResult> WebhookPost([FromForm, ModelBinder(BinderType =
         }
 
         _logger.LogTrace($"{payload.Event}: {payload.Metadata?.Guid}");
-        switch (payload.Event)
-        {
-            case "media.scrobble":
-                await Scrobble(payload, User);
-                break;
-            case "media.resume":
-            case "media.play":
-                TraktScrobble(payload, ScrobblePlayingStatus.Start);
-                break;
-            case "media.pause":
-                TraktScrobble(payload, ScrobblePlayingStatus.Pause);
-                break;
-            case "media.stop":
-                TraktScrobble(payload, ScrobblePlayingStatus.Stop);
-                break;
-        }
+
+        if (payload.Event.EqualsInvariantIgnoreCase("media.scrobble"))
+            await Scrobble(payload, User);
 
         return Ok(); //doesn't need to be an ApiStatus.OK() since really, all I take is plex.
     }
 
 
     #region Plex events
 
-    [NonAction]
-    private void TraktScrobble(PlexEvent evt, ScrobblePlayingStatus type)
-    {
-        var metadata = evt.Metadata;
-        var (episode, _) = GetEpisode(metadata);
-
-        if (episode == null) return;
-
-        var vl = RepoFactory.VideoLocal.GetByAniDBEpisodeID(episode.AniDB_EpisodeID).FirstOrDefault();
-        if (vl == null || vl.Duration == 0) return;
-
-        var per = 100 *
-                  (metadata.ViewOffset /
-                   (float)vl.Duration); //this will be nice if plex would ever give me the duration, so I don't have to guess it.
-
-        _traktHelper.Scrobble(episode, type, per);
-    }
-
     [NonAction]
     private async Task Scrobble(PlexEvent data, SVR_JMMUser user)
     {

Shoko.Server/API/v1/Implementations/ShokoServiceImplementation/ShokoServiceImplementation_Providers.cs

@@ -364,38 +364,7 @@ public CL_Response<bool> TraktFriendRequestApprove(string friendUsername)
     [HttpPost("Trakt/Scrobble/{animeId}/{type}/{progress}/{status}")]
     public int TraktScrobble(int animeId, int type, int progress, int status)
     {
-        try
-        {
-            var statusTraktV2 = ScrobblePlayingStatus.Start;
-
-            switch (status)
-            {
-                case (int)ScrobblePlayingStatus.Start:
-                    statusTraktV2 = ScrobblePlayingStatus.Start;
-                    break;
-                case (int)ScrobblePlayingStatus.Pause:
-                    statusTraktV2 = ScrobblePlayingStatus.Pause;
-                    break;
-                case (int)ScrobblePlayingStatus.Stop:
-                    statusTraktV2 = ScrobblePlayingStatus.Stop;
-                    break;
-            }
-
-            var isValidProgress = float.TryParse(progress.ToString(), out var progressTrakt);
-
-            if (isValidProgress)
-            {
-                var animeEpisode = RepoFactory.AnimeEpisode.GetByID(animeId);
-                return _traktHelper.Scrobble(animeEpisode, statusTraktV2, progressTrakt);
-            }
-
-            return 500;
-        }
-        catch (Exception ex)
-        {
-            _logger.LogError(ex, "{ex}", ex.ToString());
-            return 500;
-        }
+        return 200;
     }
 
     [HttpPost("Trakt/Refresh/{traktID}")]

Shoko.Server/API/v3/Controllers/FileController.cs

@@ -21,7 +21,6 @@
 using Shoko.Server.API.v3.Models.Shoko;
 using Shoko.Server.Extensions;
 using Shoko.Server.Models;
-using Shoko.Server.Providers.TraktTV;
 using Shoko.Server.Repositories;
 using Shoko.Server.Repositories.Cached;
 using Shoko.Server.Scheduling;
@@ -57,15 +56,13 @@ public class FileController : BaseController
 
     internal const string FileLocationNotFoundWithLocationID = "No File.Location entry for the given locationID.";
 
-    private readonly TraktTVHelper _traktHelper;
     private readonly ISchedulerFactory _schedulerFactory;
     private readonly VideoLocalService _vlService;
     private readonly VideoLocal_PlaceService _vlPlaceService;
     private readonly VideoLocal_UserRepository _vlUsers;
     private readonly IUserDataService _userDataService;
 
     public FileController(
-        TraktTVHelper traktHelper,
         ISchedulerFactory schedulerFactory,
         ISettingsProvider settingsProvider,
         VideoLocal_PlaceService vlPlaceService,
@@ -74,7 +71,6 @@ public FileController(
         VideoLocalService vlService
     ) : base(settingsProvider)
     {
-        _traktHelper = traktHelper;
         _vlPlaceService = vlPlaceService;
         _vlUsers = vlUsers;
         _userDataService = watchedService;
@@ -765,7 +761,7 @@ public async Task<ActionResult> SetWatchedStatusOnFile([FromRoute, Range(1, int.
     /// </summary>
     /// <param name="fileID">VideoLocal ID. Watch status and resume position is kept per file, regardless of how many duplicates the file has.</param>
     /// <param name="eventName">The name of the event that triggered the scrobble.</param>
-    /// <param name="episodeID">The episode id to scrobble to trakt.</param>
+    /// <param name="episodeID">The episode id to scrobble.</param>
     /// <param name="watched">True if file should be marked as watched, false if file should be unmarked, or null if it shall not be updated.</param>
     /// <param name="resumePosition">Number of ticks into the video to resume from, or null if it shall not be updated.</param>
     /// <returns></returns>
@@ -789,30 +785,6 @@ public async Task<ActionResult> ScrobbleFileAndEpisode([FromRoute, Range(1, int.
             playbackPositionTicks = TimeSpan.Zero;
         }
 
-        switch (eventName)
-        {
-            // The playback was started.
-            case "play":
-            // The playback was resumed after a pause.
-            case "resume":
-                ScrobbleToTrakt(episode, (float)(playbackPositionTicks / totalDurationTicks), ScrobblePlayingStatus.Start);
-                break;
-            // The playback was paused.
-            case "pause":
-                ScrobbleToTrakt(episode, (float)(playbackPositionTicks / totalDurationTicks), ScrobblePlayingStatus.Pause);
-                break;
-            // The playback was ended.
-            case "stop":
-                ScrobbleToTrakt(episode, (float)(playbackPositionTicks / totalDurationTicks), ScrobblePlayingStatus.Stop);
-                break;
-            // The playback is still active, but the playback position changed.
-            case "scrobble":
-                break;
-            // A user interaction caused the watch state to change.
-            case "user-interaction":
-                break;
-        }
-
         var reason = eventName switch
         {
             "play" => UserDataSaveReason.PlaybackStart,
@@ -839,15 +811,6 @@ public async Task<ActionResult> ScrobbleFileAndEpisode([FromRoute, Range(1, int.
         return NoContent();
     }
 
-    [NonAction]
-    private void ScrobbleToTrakt(SVR_AnimeEpisode episode, float percentage, ScrobblePlayingStatus status)
-    {
-        if (User.IsTraktUser == 0)
-            return;
-
-        _traktHelper.Scrobble(episode, status, percentage);
-    }
-
     /// <summary>
     /// Mark or unmark a file as ignored.
     /// </summary>

Shoko.Server/Providers/TraktTV/Contracts/Scrobble/TraktScrobble.cs

@@ -14,19 +14,6 @@ public enum TraktSyncType
     HistoryRemove = 2
 }
 
-public enum ScrobblePlayingStatus
-{
-    Start = 1,
-    Pause = 2,
-    Stop = 3
-}
-
-public enum ScrobblePlayingType
-{
-    movie = 1,
-    episode = 2
-}
-
 public static class TraktStatusCodes
 {
     // http://docs.trakt.apiary.io/#introduction/status-codes

Shoko.Server/Providers/TraktTV/Contracts/Scrobble/TraktScrobbleItem.cs

@@ -13,7 +13,6 @@
 using Shoko.Server.Extensions;
 using Shoko.Server.Models;
 using Shoko.Server.Providers.TraktTV.Contracts;
-using Shoko.Server.Providers.TraktTV.Contracts.Scrobble;
 using Shoko.Server.Providers.TraktTV.Contracts.Sync;
 using Shoko.Server.Repositories;
 using Shoko.Server.Settings;
@@ -460,84 +459,6 @@ private void SyncHistory(TraktSyncType syncType, TraktSync syncItems)
         }
     }
 
-    public int Scrobble(SVR_AnimeEpisode episode, ScrobblePlayingStatus scrobbleStatus, float progress)
-    {
-        try
-        {
-            var settings = _settingsProvider.GetSettings();
-            if (!settings.TraktTv.Enabled || string.IsNullOrEmpty(settings.TraktTv.AuthToken))
-            {
-                return 401;
-            }
-
-            string url;
-            switch (scrobbleStatus)
-            {
-                case ScrobblePlayingStatus.Start:
-                    url = TraktURIs.SetScrobbleStart;
-                    break;
-                case ScrobblePlayingStatus.Pause:
-                    url = TraktURIs.SetScrobblePause;
-                    break;
-                case ScrobblePlayingStatus.Stop:
-                    url = TraktURIs.SetScrobbleStop;
-                    break;
-                default:
-                    return 400;
-            }
-
-            // TODO: Figure out scrobbling if the episode has multiple links
-            var tmdbEpisodeIds = GetTmdbEpisodeIdsFromEpisode(episode);
-            var tmdbMovieIds = GetTmdbMovieIdsFromEpisode(episode);
-
-            if (tmdbEpisodeIds.Count == 0 && tmdbMovieIds.Count == 0)
-            {
-                _logger.LogWarning(
-                    "TraktTVHelper.Scrobble: No TMDB IDs found for: Anime Episode ID: {ID} Anime: {Title}", episode.AnimeEpisodeID,
-                    episode.PreferredTitle);
-                return 404;
-            }
-
-            var retData = string.Empty;
-            var scrobble = new TraktScrobble
-            {
-                Progress = progress
-            };
-
-            if (tmdbEpisodeIds.Count > 0)
-            {
-                scrobble.Episode = new TraktScrobbleItem
-                {
-                    Ids = new TraktIds
-                    {
-                        TmdbID = tmdbEpisodeIds.First()
-                    }
-                };
-            }
-            else
-            {
-                scrobble.Movie = new TraktScrobbleItem
-                {
-                    Ids = new TraktIds
-                    {
-                        TmdbID = tmdbEpisodeIds.First()
-                    }
-                };
-            }
-
-            var json = JsonConvert.SerializeObject(scrobble);
-            TraktTVRateLimiter.Instance.EnsureRate();
-            SendData(url, json, "POST", BuildRequestHeaders(), ref retData);
-
-            return 200;
-        }
-        catch (Exception ex)
-        {
-            _logger.LogError(ex, "Error in TraktTVHelper.Scrobble");
-            return 500;
-        }
-    }
-
     #endregion
 
     #region Get Data From Trakt