Commit 3713646
authored
[PageActions] [FullscreenBar] Deprecate (#13965)
<!--
☝️How to write a good PR title:
- Prefix it with [ComponentName] (if applicable), for example: [Button]
- Start with a verb, for example: Add, Delete, Improve, Fix…
- Give as much context as necessary and as little as possible
- Open it as a draft if it’s a work in progress
-->
### WHY are these changes introduced?
1.
[PageActions](https://polaris-react.shopify.com/components/actions/page-actions)
are a legacy UX solution. Page actions should instead be presented via
the [contextual save
bar](https://shopify.dev/docs/api/app-bridge-library/apis/save-bar) (in
the case of Save) OR via the [Polaris
Page](https://polaris-react.shopify.com/components/layout-and-structure/page)
action props (i.e. `primaryAction`, `secondaryActions`, `actionGroups`).
2.
[FullscreenBar](https://polaris-react.shopify.com/components/navigation/fullscreen-bar)
is a legacy UX solution. Instead [max variant
modals](https://shopify.dev/docs/api/app-bridge-library/web-components/ui-modal)
should be used in combination with the
[SaveBar](https://shopify.dev/docs/api/app-bridge-library/apis/save-bar)
and
[TitleBar](https://shopify.dev/docs/api/app-bridge-library/web-components/ui-title-bar).
The [App Design
Guidelines](https://shopify.dev/docs/apps/design/app-structure)
explicitly state not to use FullscreenBar.
<img width="840" height="324" alt="01-40-tyci1-sxt9y"
src="https://github.com/user-attachments/assets/66ad93f8-9c08-44bc-8eba-03888ff834f6"
/>
Built for Shopify requirement
[4.1.6](https://shopify.dev/docs/apps/launch/built-for-shopify/requirements#use-modals-appropriately),
lists using FullscreenBar as a failure example.
<img width="910" height="824" alt="01-43-t7px5-mzkqr"
src="https://github.com/user-attachments/assets/503c87b1-910b-4003-a821-4b67b20a597d"
/>
<!--
Context about the problem that’s being addressed.
-->
### WHAT is this pull request doing?
This PR moves both the `PageActions` and `FullscreenBar` components to
the Deprecated section in the nav. It also displays a "Deprecated"
banner on both of the component pages.
<img width="1305" height="875" alt="01-59-c5awl-pclmj"
src="https://github.com/user-attachments/assets/c5edc48b-aa77-4e33-ba95-a30c286308d0"
/>
<img width="1307" height="823" alt="01-58-qmsur-50290"
src="https://github.com/user-attachments/assets/539050a1-89f3-4269-bd87-b8292e480bca"
/>
### How to 🎩
🖥 [Local development
instructions](https://github.com/Shopify/polaris/blob/main/README.md#install-dependencies-and-build-workspaces)
🗒 [General tophatting
guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md)
📄 [Changelog
guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog)
### 🎩 checklist
- [x] Tested a
[snapshot](https://github.com/Shopify/polaris/blob/main/documentation/Releasing.md#-snapshot-releases)
- [x] Tested on
[mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing)
- [x] Tested on [multiple
browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers)
- [x] Tested for
[accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md)
- [x] Updated the component's `README.md` with documentation changes
- [x] [Tophatted
documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md)
changes in the style guide1 parent 34ade0c commit 3713646
File tree
6 files changed
+30
-15
lines changed- polaris.shopify.com
- content/components/deprecated
- public/images/components/deprecated
6 files changed
+30
-15
lines changedLines changed: 11 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
17 | | - | |
| 17 | + | |
| 18 | + | |
18 | 19 | | |
19 | 20 | | |
20 | 21 | | |
| |||
25 | 26 | | |
26 | 27 | | |
27 | 28 | | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
28 | 37 | | |
29 | 38 | | |
30 | 39 | | |
| |||
Lines changed: 8 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
| 4 | + | |
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| |||
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
28 | | - | |
| 28 | + | |
| 29 | + | |
29 | 30 | | |
30 | 31 | | |
31 | 32 | | |
| |||
36 | 37 | | |
37 | 38 | | |
38 | 39 | | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
39 | 45 | | |
40 | 46 | | |
41 | 47 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
| 5 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
237 | 237 | | |
238 | 238 | | |
239 | 239 | | |
240 | | - | |
241 | | - | |
242 | | - | |
243 | | - | |
244 | | - | |
245 | 240 | | |
246 | 241 | | |
247 | 242 | | |
| |||
260 | 255 | | |
261 | 256 | | |
262 | 257 | | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
263 | 263 | | |
264 | 264 | | |
265 | 265 | | |
| |||
285 | 285 | | |
286 | 286 | | |
287 | 287 | | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
288 | 293 | | |
289 | 294 | | |
290 | 295 | | |
| |||
585 | 590 | | |
586 | 591 | | |
587 | 592 | | |
588 | | - | |
589 | | - | |
590 | | - | |
591 | | - | |
592 | | - | |
593 | 593 | | |
594 | 594 | | |
595 | 595 | | |
| |||
0 commit comments