refactor for _voteTransaction and better revertedTxns.json file handling

Author: mauri-rsk

federator/package.json

@@ -14,7 +14,7 @@
   "scripts": {
     "start": "node ./src/main.js",
     "test": "jest --detectOpenHandles test/",
-    "integrationTest": "rm ./db/lastBlock.txt --force && rm ./db/side-fed/lastBlock.txt --force && node ./integrationTest/integrationTest.js",
+    "integrationTest": "rm -rf ./db/* && node ./integrationTest/integrationTest.js",
     "integrationHeartbeatTest": "rm -rf ./db/* && node ./integrationTest/integrationHeartbeatTest.js && rm heartbeat.log",
     "clean": "rm -rf ./db/*"
   },

federator/src/lib/Federator.js

@@ -281,18 +281,20 @@ module.exports = class Federator {
                 typeId
             }).encodeABI();
 
-            let revertedTxns = JSON.parse(fs.readFileSync(this.revertedTxnsPath, 'utf8'));
-            this.logger.info(`read these transactions from reverted transactions file`, revertedTxns);
+            let revertedTxns = {};
+            if (fs.existsSync(this.revertedTxnsPath)) {
+                revertedTxns = JSON.parse(fs.readFileSync(this.revertedTxnsPath, 'utf8'));
+                this.logger.info(`read these transactions from reverted transactions file`, revertedTxns);
+            }
 
-            let receipt;
             if (revertedTxns[txId]) {
                 this.logger.info(`Skipping Voting Transfer ${txId} since it's marked as reverted.`, revertedTxns[txId])
-            } else {
-                receipt = await transactionSender.sendTransaction(fedContract.getAddress(), txData, 0, this.config.privateKey);
+                return false;
             }
+            const receipt = await transactionSender.sendTransaction(fedContract.getAddress(), txData, 0, this.config.privateKey);
 
-            if(receipt && receipt.status == false) {
-                this._saveRevertedTxns(
+            if(receipt.status == false) {
+                fs.writeFileSync(
                     this.revertedTxnsPath,
                     JSON.stringify({
                         ...revertedTxns,
@@ -323,10 +325,4 @@ module.exports = class Federator {
             fs.writeFileSync(path, value.toString());
         }
     }
-
-    _saveRevertedTxns(path, value) {
-        if (value) {
-            fs.writeFileSync(path, value.toString());
-        }
-    }
 }