Skip to content

Commit e11ad15

Browse files
committed
Merge pull request redis#301 from go-redis/fix/cmd-bytes
Don't convert bytes to string in Cmd (interface{} value).
2 parents 1fbb109 + 956758d commit e11ad15

File tree

2 files changed

+2
-8
lines changed

2 files changed

+2
-8
lines changed

command.go

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -165,13 +165,7 @@ func (cmd *Cmd) readReply(cn *pool.Conn) error {
165165
cmd.err = err
166166
return cmd.err
167167
}
168-
if v, ok := val.([]byte); ok {
169-
// Convert to string to preserve old behaviour.
170-
// TODO: remove in v4
171-
cmd.val = string(v)
172-
} else {
173-
cmd.val = val
174-
}
168+
cmd.val = val
175169
return nil
176170
}
177171

redis_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ var _ = Describe("Client", func() {
132132
cmd := redis.NewCmd("PING")
133133
client.Process(cmd)
134134
Expect(cmd.Err()).NotTo(HaveOccurred())
135-
Expect(cmd.Val()).To(Equal("PONG"))
135+
Expect(cmd.Val()).To(Equal([]byte("PONG")))
136136
})
137137

138138
It("should retry command on network error", func() {

0 commit comments

Comments
 (0)