Skip to content
This repository was archived by the owner on Sep 22, 2025. It is now read-only.

Commit dcf4c44

Browse files
committed
Fix bug when renaming column the same
1 parent 86a43f2 commit dcf4c44

File tree

3 files changed

+4
-12
lines changed

3 files changed

+4
-12
lines changed

dist/core/frame.js

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -136,9 +136,6 @@ var DataFrame = function () {
136136
index += 1;
137137
var row = {};
138138
_this3.columns.forEach(function (k) {
139-
console.log(k);
140-
console.log(_this3);
141-
console.log(_this3[k]);
142139
row[k] = _this3[k].values.get(index);
143140
});
144141
return {
@@ -197,7 +194,7 @@ var DataFrame = function () {
197194
_this4[prevColumn].name = k;
198195
_this4[k] = _this4[prevColumn];
199196

200-
delete _this4[prevColumn];
197+
if (prevColumn !== k) delete _this4[prevColumn];
201198
});
202199
this._columns = columns;
203200
}

src/es6/core/frame.js

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -77,9 +77,6 @@ export default class DataFrame {
7777
index += 1;
7878
const row = {};
7979
this.columns.forEach((k) => {
80-
console.log(k);
81-
console.log(this);
82-
console.log(this[k]);
8380
row[k] = this[k].values.get(index);
8481
});
8582
return {
@@ -115,7 +112,8 @@ export default class DataFrame {
115112
this[prevColumn].name = k;
116113
this[k] = this[prevColumn];
117114

118-
delete this[prevColumn];
115+
if (prevColumn !== k)
116+
delete this[prevColumn];
119117
});
120118
this._columns = columns;
121119
}

src/js/core/frame.js

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -136,9 +136,6 @@ var DataFrame = function () {
136136
index += 1;
137137
var row = {};
138138
_this3.columns.forEach(function (k) {
139-
console.log(k);
140-
console.log(_this3);
141-
console.log(_this3[k]);
142139
row[k] = _this3[k].values.get(index);
143140
});
144141
return {
@@ -197,7 +194,7 @@ var DataFrame = function () {
197194
_this4[prevColumn].name = k;
198195
_this4[k] = _this4[prevColumn];
199196

200-
delete _this4[prevColumn];
197+
if (prevColumn !== k) delete _this4[prevColumn];
201198
});
202199
this._columns = columns;
203200
}

0 commit comments

Comments
 (0)