Skip to content

Commit edd0846

Browse files
committed
In JavaScriptEngineSwitcher.Msie added support of MSIE JavaScript Engine version 2.2.0
1 parent 02c1410 commit edd0846

File tree

7 files changed

+30
-13
lines changed

7 files changed

+30
-13
lines changed

NuGet/JavaScriptEngineSwitcher.Msie/JavaScriptEngineSwitcher.Msie.nuspec

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,22 +12,23 @@
1212
<requireLicenseAcceptance>false</requireLicenseAcceptance>
1313
<description>JavaScriptEngineSwitcher.Msie contains adapter `MsieJsEngine` (wrapper for the MSIE JavaScript Engine for .Net (http://github.com/Taritsyn/MsieJavaScriptEngine)). For correct working of the MSIE JavaScript Engine it is recommended to install Internet Explorer 9 and above on a server.</description>
1414
<summary>JavaScriptEngineSwitcher.Msie contains adapter `MsieJsEngine` (wrapper for the MSIE JavaScript Engine for .Net).</summary>
15-
<releaseNotes>Added support of .NET Core 1.0.4.</releaseNotes>
15+
<releaseNotes>1. Added support of .NET Core 1.0.4;
16+
2. Added support of MSIE JavaScript Engine version 2.2.0.</releaseNotes>
1617
<copyright>Copyright (c) 2013-2017 Andrey Taritsyn - http://www.taritsyn.ru</copyright>
1718
<language>en-US</language>
1819
<tags>JavaScriptEngineSwitcher JavaScript ECMAScript MSIE IE Chakra</tags>
1920
<dependencies>
2021
<group targetFramework=".NETFramework4.0-Client">
21-
<dependency id="MsieJavaScriptEngine" version="2.1.2" />
22+
<dependency id="MsieJavaScriptEngine" version="2.2.0" />
2223
<dependency id="JavaScriptEngineSwitcher.Core" version="2.2.0" />
2324
</group>
2425
<group targetFramework=".NETFramework4.5">
25-
<dependency id="MsieJavaScriptEngine" version="2.1.2" />
26+
<dependency id="MsieJavaScriptEngine" version="2.2.0" />
2627
<dependency id="JavaScriptEngineSwitcher.Core" version="2.2.0" />
2728
</group>
2829
<group targetFramework=".NETStandard1.3">
2930
<dependency id="NETStandard.Library" version="1.6.0" />
30-
<dependency id="MsieJavaScriptEngine" version="2.1.2" />
31+
<dependency id="MsieJavaScriptEngine" version="2.2.0" />
3132
<dependency id="JavaScriptEngineSwitcher.Core" version="2.2.0" />
3233
</group>
3334
</dependencies>

NuGet/JavaScriptEngineSwitcher.Msie/readme.txt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,8 @@
1919
=============
2020
RELEASE NOTES
2121
=============
22-
Added support of .NET Core 1.0.4.
22+
1. Added support of .NET Core 1.0.4;
23+
2. Added support of MSIE JavaScript Engine version 2.2.0.
2324

2425
=============
2526
DOCUMENTATION

src/JavaScriptEngineSwitcher.ChakraCore/ChakraCoreJsEngine.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ public sealed class ChakraCoreJsEngine : JsEngineBase
4545
/// <summary>
4646
/// JS source context
4747
/// </summary>
48-
JsSourceContext _jsSourceContext = JsSourceContext.FromIntPtr(IntPtr.Zero);
48+
private JsSourceContext _jsSourceContext = JsSourceContext.FromIntPtr(IntPtr.Zero);
4949

5050
/// <summary>
5151
/// Set of external objects

src/JavaScriptEngineSwitcher.Msie.Net4/JavaScriptEngineSwitcher.Msie.Net40.csproj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,8 @@
4545
</ProjectReference>
4646
</ItemGroup>
4747
<ItemGroup>
48-
<Reference Include="MsieJavaScriptEngine, Version=2.1.2.0, Culture=neutral, PublicKeyToken=a3a2846a37ac0d3e, processorArchitecture=MSIL">
49-
<HintPath>..\..\packages\MsieJavaScriptEngine.2.1.2\lib\net40-client\MsieJavaScriptEngine.dll</HintPath>
48+
<Reference Include="MsieJavaScriptEngine, Version=2.2.0.0, Culture=neutral, PublicKeyToken=a3a2846a37ac0d3e, processorArchitecture=MSIL">
49+
<HintPath>..\..\packages\MsieJavaScriptEngine.2.2.0\lib\net40-client\MsieJavaScriptEngine.dll</HintPath>
5050
<Private>True</Private>
5151
</Reference>
5252
<Reference Include="System" />
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
<?xml version="1.0" encoding="utf-8"?>
22
<packages>
3-
<package id="MsieJavaScriptEngine" version="2.1.2" targetFramework="net40-Client" />
3+
<package id="MsieJavaScriptEngine" version="2.2.0" targetFramework="net40-Client" />
44
</packages>

src/JavaScriptEngineSwitcher.Msie/JavaScriptEngineSwitcher.Msie.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
</PropertyGroup>
2424

2525
<ItemGroup>
26-
<PackageReference Include="MsieJavaScriptEngine" Version="2.1.2" />
26+
<PackageReference Include="MsieJavaScriptEngine" Version="2.2.0" />
2727

2828
<ProjectReference Include="..\JavaScriptEngineSwitcher.Core\JavaScriptEngineSwitcher.Core.csproj" />
2929
</ItemGroup>

src/JavaScriptEngineSwitcher.Msie/MsieJsEngine.cs

Lines changed: 18 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -150,12 +150,17 @@ private JsRuntimeException ConvertMsieJsRuntimeExceptionToJsRuntimeException(
150150
#region JsEngineBase implementation
151151

152152
protected override object InnerEvaluate(string expression)
153+
{
154+
return InnerEvaluate(expression, null);
155+
}
156+
157+
protected override object InnerEvaluate(string expression, string documentName)
153158
{
154159
object result;
155160

156161
try
157162
{
158-
result = _jsEngine.Evaluate(expression);
163+
result = _jsEngine.Evaluate(expression, documentName);
159164
}
160165
catch (OriginalJsRuntimeException e)
161166
{
@@ -169,16 +174,26 @@ protected override object InnerEvaluate(string expression)
169174

170175
protected override T InnerEvaluate<T>(string expression)
171176
{
172-
object result = InnerEvaluate(expression);
177+
return InnerEvaluate<T>(expression, null);
178+
}
179+
180+
protected override T InnerEvaluate<T>(string expression, string documentName)
181+
{
182+
object result = InnerEvaluate(expression, documentName);
173183

174184
return OriginalTypeConverter.ConvertToType<T>(result);
175185
}
176186

177187
protected override void InnerExecute(string code)
188+
{
189+
InnerExecute(code, null);
190+
}
191+
192+
protected override void InnerExecute(string code, string documentName)
178193
{
179194
try
180195
{
181-
_jsEngine.Execute(code);
196+
_jsEngine.Execute(code, documentName);
182197
}
183198
catch (OriginalJsRuntimeException e)
184199
{

0 commit comments

Comments
 (0)