Skip to content

Commit 540592e

Browse files
committed
docs: fix types in docs and comments
1 parent 0500445 commit 540592e

File tree

6 files changed

+25
-32
lines changed

6 files changed

+25
-32
lines changed

PROD_CHECKLIST.md

Lines changed: 10 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,22 @@
11
If you are done with your hackathon and thinking about launching your project into production, or if you are just using this boilerplate to start your soon to be in production application, this document is a checklist to help you get your application production ready.
22

3-
- Remove Unused code and configs
4-
- Add a proxy such as Cloudflare in front of your production deployment. Adjust numberOfProxies logic in app.js if needed.
3+
- Remove unused code and configs
4+
- Add a proxy such as Cloudflare in front of your production deployment. Adjust the numberOfProxies logic in app.js if needed
55
- Update the session cookie configs with sameSite attribute, domain, and path
66
- Add Terms of Service and Privacy Policy
7-
- Update `License.md` and the relevant license field in package.json if applicable - See [npm's doc](https://docs.npmjs.com/files/package.json#license).
7+
- Update `LICENSE.md` and the relevant license field in package.json if applicable - See [npm's doc](https://docs.npmjs.com/files/package.json#license).
88
- Add [sitemap.xml](https://en.wikipedia.org/wiki/Sitemaps) and [robots.txt](https://moz.com/learn/seo/robotstxt)
99
- Update Google Analytics ID
1010
- Add Facebook App/Pixel ID
1111
- Add Winston Logging, and replace console.log statements with Winston; have a process for monitoring errors to identify bugs or other issues after launch.
1212
- SEO and Social Media Improvements
1313
- Create a deployment pipeline with a pre-prod/integration test stage.
1414
- (optional) Add email verification _Some experimental data has shown that bogus email addresses are not a significant problem in many cases_
15-
- (optional) Add a filter with [disposable-email-domains](https://www.npmjs.com/package/disposable-email-domains). _Some experimental data has shown that use of disposable emails is typically rare, and in many cases it might not be worth add the filter._
15+
- (optional) Add a filter with [disposable-email-domains](https://www.npmjs.com/package/disposable-email-domains). _Some experimental data has shown that use of disposable emails is typically rare, and in many cases it might not be worth adding the filter._
1616

1717
### Remove unused code and configs
1818

19-
The following is a list of various codes that you may not potential be using and you could remove depending on your application:
19+
The following is a list of various code that you may not potentially be using and you could remove depending on your application:
2020

2121
- Unused keys from .env file
2222
- /controllers/api.js entirely
@@ -27,7 +27,7 @@ The following is a list of various codes that you may not potential be using and
2727
- Openshift env references
2828
- csrf check exception for /api/upload
2929
- All API example routes
30-
- OAuth routes for authentications that you are not using (i.e.Github, LinkedIn, etc based on your app)
30+
- OAuth routes for authentications that you are not using (i.e. GitHub, LinkedIn, etc. based on your app)
3131
- All OAuth authorization routes
3232
- passport.js all references and functions related to:
3333
- Github, LinkedIn, OpenID, OAuth, OAuth2
@@ -38,11 +38,11 @@ The following is a list of various codes that you may not potential be using and
3838
- /test
3939
- Replace E2E and API example tests with new tests for your application
4040
- views/account/login.pug
41-
- Some or all of the last form-group set which are the social login choices
41+
- Some or all of the last form-group set, which are the social login choices
4242
- views/account/profile.pug
43-
- Link/unlink buttons for Github, LinkedIn, steam
44-
- Removed readme, changelog, this guide, docker related files if not using them
45-
- Create a domain whitelist for your app in Here's developer portal if you are using the Here's map API.
43+
- Link/unlink buttons for GitHub, LinkedIn, Steam
44+
- Remove README, changelog, this guide, Docker-related files if not using them
45+
- Create a domain whitelist for your app in Here's developer portal if you are using the HERE Maps API.
4646
- Add unit tests so you can test and incorporate dependency and upstream updates with less effort. GPT tools may create some good unit tests with very low effort.
4747

4848
### Search Engine Optimization (SEO)
@@ -62,8 +62,3 @@ Note that SEO only applies to the pages that will be publicly visible with no au
6262
```
6363
<meta name="Description" content="Description about the page.">
6464
```
65-
66-
- Add the Google Plus page as the publisher of the website.
67-
```
68-
<link rel=”publisher” href=”https://plus.google.com/+your_business_google_plus_id”>
69-
```

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -639,7 +639,7 @@ Required to run the project before your modifications
639639
| pdfjs-dist | PDF parser |
640640
| pug | Template engine for Express. |
641641
| sass | Sass compiler to generate CSS with superpowers. |
642-
| stripe | Offical Stripe API library. |
642+
| stripe | Official Stripe API library. |
643643
| twilio | Twilio API library. |
644644
| twitch-passport | Sign-in with Twitch plugin. |
645645
| validator | A library of string validators and sanitizers. |

SECURITY.md

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@
22

33
## Supported Versions
44

5-
Use this section to tell people about which versions of your project are currently being supported with security updates.
6-
75
| Version | Supported |
86
| ------- | ------------------ |
97
| latest | :white_check_mark: |
@@ -14,12 +12,12 @@ Use this section to tell people about which versions of your project are current
1412

1513
PRIOR TO SUBMITTING SECURITY CONCERNS/REPORTS:
1614

17-
1. Research Wikipedia and other sources about hackathons to get more familiar with the potential uses of this project, the intended settings, and usage environments.
18-
2. Read README.MD entirely, including the intro paragraph and steps for Obtaining API Keys which includes replacing the .env values. The provided values in the .env file are placeholders, not a batch of keys exposed thru GitHub.
19-
3. Read prod-checklist.md. Hackathon projects are not production projects, and this checklist is to help users with their next steps to move from a prototype state to a production state.
15+
1. Research Wikipedia and other sources about hackathons to become more familiar with the potential uses of this project, the intended settings, and usage environments.
16+
2. Read README.md entirely, including the introduction and the steps for obtaining API keys, which includes replacing the .env values. The provided values in the .env file are placeholders, not a batch of keys exposed through GitHub.
17+
3. Read PROD_CHECKLIST.md. Hackathon projects are not production projects, and this checklist is to help users with their next steps to move from a prototype state to a production state.
2018

2119
SUBMITTING SECURITY CONCERNS/REPORTS:
2220

2321
1. Complete the above steps 1 to 3.
2422
2. If you still believe you have identified an issue, please submit it as a GitHub Issue at https://github.com/sahat/hackathon-starter/issues with the relevant information for discussion and clarification.
25-
Submissions requiring registration with 3rd party websites will be marked/reported as spam.
23+
Submissions requiring registration with third-party websites will be marked/reported as spam.

controllers/ai.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -620,7 +620,7 @@ Provide the output in this JSON structure:
620620
}
621621
Replace <selected_department> with the name of the most relevant department from the list above. If the inquiry spans multiple categories, choose the department that is most likely to address the customer's issue promptly and effectively.`;
622622

623-
// Image Uploade middleware for Camera uploads
623+
// Image upload middleware for camera uploads
624624
const createImageUploader = () => {
625625
const memoryStorage = multer.memoryStorage();
626626
return multer({

controllers/user.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -138,9 +138,9 @@ exports.getSignup = (req, res) => {
138138
};
139139

140140
/**
141-
* Helper to send passwordless login link if a user is trying to create an account
141+
* Helper to send a passwordless login link if a user is trying to create an account
142142
* but we already have an account for that email address.
143-
* This process with ambigious flash messages is a part of the security measure to
143+
* This process with ambiguous flash messages is part of the security measures to
144144
* mitigate account enumeration attacks.
145145
*/
146146
async function sendPasswordlessLoginLinkIfUserExists(user, req) {
@@ -177,7 +177,7 @@ Thank you!\n`,
177177
}
178178

179179
/**
180-
* Helper to send passwordless signup link for new users.
180+
* Helper to send a passwordless signup link for new users.
181181
*/
182182
async function sendPasswordlessSignupLink(user, req) {
183183
const token = await User.generateToken();
@@ -319,8 +319,8 @@ exports.postUpdateProfile = async (req, res, next) => {
319319
} else {
320320
console.log('Error updating profile', err);
321321
}
322-
// Generic error message for the user. Do not reveal the cause of the error tsuch as
323-
// the new email being in the system to the user to avoid enumeration vulenrability.
322+
// Generic error message for the user. Do not reveal the cause of the error, such as
323+
// the new email being in the system, to the user to avoid enumeration vulnerability.
324324
req.flash('errors', {
325325
msg: "We encountered an issue updating your email address. If you suspect you have duplicate accounts, please log in with the other email address you've used or contact support for assistance. You can delete duplicate accounts from your account settings.",
326326
});

test/TESTING.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -80,10 +80,10 @@ Use one script with project selection:
8080
```bash
8181
npm run test:e2e:live # All E2E tests with live API calls
8282
npm run test:e2e:replay # All E2E tests with previously recorded API responses
83-
npm run test:custom -- --project=chromium-record # E2E with recording API calls (record fixtures)
84-
npm run test:custom -- --project=chromium-nokey-live # Only E2E tests that don't require API keys (live)
85-
npm run test:custom -- --project=chromium-nokey-replay # Only E2E tests that don't require API keys (replay fixtures)
86-
npm run test:custom -- --project=chromium-nokey-record # Only E2E tests that don't require API keys (record fixtures)
83+
npm run test:e2e:custom -- --project=chromium-record # E2E with recording API calls (record fixtures)
84+
npm run test:e2e:custom -- --project=chromium-nokey-live # Only E2E tests that don't require API keys (live)
85+
npm run test:e2e:custom -- --project=chromium-nokey-replay # Only E2E tests that don't require API keys (replay fixtures)
86+
npm run test:e2e:custom -- --project=chromium-nokey-record # Only E2E tests that don't require API keys (record fixtures)
8787
```
8888

8989
### Run a Single E2E Test File

0 commit comments

Comments
 (0)