[hdr] removed white point, this is an old school way of defining paper white on screen, we'll use real physics to determine it while tonemapping

Author: PanosK92

data/shaders/common_resources.hlsl

@@ -58,14 +58,14 @@ struct FrameBufferData
     float camera_last_movement_time;
     float hdr_enabled;
     float hdr_max_nits;
-    float hdr_white_point; // future me: not used, can be removed
+    float padding;
 
     float3 camera_position_previous;
     float resolution_scale;
 
     double time;
     float camera_fov;
-    float padding;
+    float padding2;
 
     float3 wind;
     float gamma;

source/editor/Widgets/RenderOptions.cpp

@@ -320,11 +320,6 @@ void RenderOptions::OnTickVisible()
                     option_value("Gamma", Renderer_Option::Gamma);
                     ImGui::EndDisabled();
                     option_value("Exposure adaptation speed", Renderer_Option::AutoExposureAdaptationSpeed, "Negative value disables adaptation");
-
-                    bool hdr_enabled = Renderer::GetOption<bool>(Renderer_Option::Hdr);
-                    ImGui::BeginDisabled(!hdr_enabled);
-                    option_value("White point (nits)", Renderer_Option::WhitePoint, "Target luminance of peak white", 1.0f);
-                    ImGui::EndDisabled();
                 }
 
                 if (option("Tone Mapping"))

source/runtime/Core/Settings.cpp

@@ -67,7 +67,6 @@ namespace spartan
                 case Renderer_Option::FilmGrain:                   return "FilmGrain";
                 case Renderer_Option::ChromaticAberration:         return "ChromaticAberration";
                 case Renderer_Option::Anisotropy:                  return "Anisotropy";
-                case Renderer_Option::WhitePoint:                  return "WhitePoint";
                 case Renderer_Option::Tonemapping:                 return "Tonemapping";
                 case Renderer_Option::AntiAliasing_Upsampling:     return "AntiAliasing_Upsampling";
                 case Renderer_Option::Sharpness:                   return "Sharpness";

source/runtime/Rendering/Renderer.cpp

@@ -137,7 +137,6 @@ namespace spartan
             bool low_quality = RHI_Device::GetPrimaryPhysicalDevice()->IsBelowMinimumRequirements();
 
             m_options.clear();
-            SetOption(Renderer_Option::WhitePoint,                  350.0f);
             SetOption(Renderer_Option::Tonemapping,                 static_cast<float>(Renderer_Tonemapping::Max));
             SetOption(Renderer_Option::Bloom,                       1.0f);  // non-zero values activate it and control the intensity
             SetOption(Renderer_Option::MotionBlur,                  1.0f);
@@ -576,7 +575,6 @@ namespace spartan
         m_cb_frame_cpu.resolution_scale    = GetOption<float>(Renderer_Option::ResolutionScale);
         m_cb_frame_cpu.hdr_enabled         = GetOption<bool>(Renderer_Option::Hdr) ? 1.0f : 0.0f;
         m_cb_frame_cpu.hdr_max_nits        = Display::GetLuminanceMax();
-        m_cb_frame_cpu.hdr_white_point     = GetOption<float>(Renderer_Option::WhitePoint);
         m_cb_frame_cpu.gamma               = GetOption<float>(Renderer_Option::Gamma);
         m_cb_frame_cpu.camera_exposure     = World::GetCamera() ? World::GetCamera()->GetExposure() : 1.0f;
 

source/runtime/Rendering/Renderer_Buffers.h

@@ -66,14 +66,14 @@ namespace spartan
         float camera_last_movement_time;
         float hdr_enabled;
         float hdr_max_nits;
-        float hdr_white_point;
+        float padding;
 
         math::Vector3 camera_position_previous;
         float resolution_scale;
 
         double time;
         float camera_fov;
-        float padding;
+        float padding2;
 
         math::Vector3 wind;
         float gamma;

source/runtime/Rendering/Renderer_Definitions.h

@@ -59,7 +59,6 @@ namespace spartan
         Sharpness,
         Dithering,
         Hdr,
-        WhitePoint,
         Gamma,
         Vsync,
         VariableRateShading,