made begin methods consistent while eliminating duplication

soundanalogous · soundanalogous · commit f1f9a7cda5b2 · 2013-02-17T13:09:51.000-05:00
diff --git a/Firmata.cpp b/Firmata.cpp
@@ -56,7 +56,7 @@ FirmataClass::FirmataClass()
 //* Public Methods
 //******************************************************************************
 
-/* begin method for overriding default serial bitrate */
+/* begin method with default serial bitrate */
 void FirmataClass::begin(void)
 {
   begin(57600);
@@ -66,16 +66,14 @@ void FirmataClass::begin(void)
 void FirmataClass::begin(long speed)
 {
   Serial.begin(speed);
-  FirmataSerial = &Serial;
-  blinkVersion();
-  printVersion();
-  printFirmwareVersion();
+  begin(Serial);
 }
 
+/* begin method for overriding default stream */
 void FirmataClass::begin(Stream &s)
 {
   FirmataSerial = &s;
-  systemReset();
+  blinkVersion();
   printVersion();
   printFirmwareVersion();
 }

Original file line number	Diff line number	Diff line change
`@@ -56,7 +56,7 @@ FirmataClass::FirmataClass()`
`56`	`56`	`//* Public Methods`
`57`	`57`	`//******************************************************************************`
`58`	`58`
`59`		`-/* begin method for overriding default serial bitrate */`
	`59`	`+/* begin method with default serial bitrate */`
`60`	`60`	`void FirmataClass::begin(void)`
`61`	`61`	`{`
`62`	`62`	`begin(57600);`
`@@ -66,16 +66,14 @@ void FirmataClass::begin(void)`
`66`	`66`	`void FirmataClass::begin(long speed)`
`67`	`67`	`{`
`68`	`68`	`Serial.begin(speed);`
`69`		`- FirmataSerial = &Serial;`
`70`		`- blinkVersion();`
`71`		`- printVersion();`
`72`		`- printFirmwareVersion();`
	`69`	`+ begin(Serial);`
`73`	`70`	`}`
`74`	`71`
	`72`	`+/* begin method for overriding default stream */`
`75`	`73`	`void FirmataClass::begin(Stream &s)`
`76`	`74`	`{`
`77`	`75`	`FirmataSerial = &s;`
`78`		`- systemReset();`
	`76`	`+ blinkVersion();`
`79`	`77`	`printVersion();`
`80`	`78`	`printFirmwareVersion();`
`81`	`79`	`}`