Skip to content

[Test] [Build] fix: static members (#301) * Fix PreserveRequiredProperties for record class facets (#298) Record classes with required members were incorrectly generated as positional declarations (e.g., record Foo(string Bar)), which silently dropped the required modifier since C# doesn't support required on positional parameters of record classes (only record structs support this). Now, when a record class has required members, the generator uses non-positional declarations with proper required prop... #806

[Test] [Build] fix: static members (#301) * Fix PreserveRequiredProperties for record class facets (#298) Record classes with required members were incorrectly generated as positional declarations (e.g., record Foo(string Bar)), which silently dropped the required modifier since C# doesn't support required on positional parameters of record classes (only record structs support this). Now, when a record class has required members, the generator uses non-positional declarations with proper required prop...

[Test] [Build] fix: static members (#301) * Fix PreserveRequiredProperties for record class facets (#298) Record classes with required members were incorrectly generated as positional declarations (e.g., record Foo(string Bar)), which silently dropped the required modifier since C# doesn't support required on positional parameters of record classes (only record structs support this). Now, when a record class has required members, the generator uses non-positional declarations with proper required prop... #806

Triggered via workflow run March 31, 2026 15:03
@Tim-MaesTim-Maes
completed d000180
Status Success
Total duration 1m 6s
Artifacts 1

test.yml

on: workflow_run
Fit to window
Zoom out
Zoom in

Annotations

10 warnings
test: test/Facet.Tests/TestModels/GlobalNamespaceTestEntities.cs#L14
'GenerateAuditableDtosAttribute' is obsolete: 'Use GenerateDtosAttribute with ExcludeAuditFields = true instead. This attribute will be removed in a future version.'
test: src/Facet/AnalyzerReleases.Shipped.md#L5
Analyzer release file 'AnalyzerReleases.Shipped.md' has a missing or invalid release header '| Rule ID | Category | Severity | Notes |' (https://github.com/dotnet/roslyn-analyzers/blob/main/src/Microsoft.CodeAnalysis.Analyzers/ReleaseTrackingAnalyzers.Help.md)
test: src/Facet/Generators/FacetGenerators/ModelBuilder.cs#L778
Possible null reference argument for parameter 'source' in 'bool ModelBuilder.IsExpression(string source)'.
test: src/Facet/Generators/FacetGenerators/ModelBuilder.cs#L732
Dereference of a possibly null reference.
test: src/Facet/Generators/FacetGenerators/FlattenToGenerator.cs#L377
Dereference of a possibly null reference.
test: src/Facet/Generators/FacetGenerators/FlattenToGenerator.cs#L248
Possible null reference argument for parameter 'typeName' in 'FacetTargetModel? FlattenToGenerator.FindFacetModel(string typeName, Dictionary<string, FacetTargetModel> facetLookup)'.
test: src/Facet/Generators/FacetGenerators/FlattenToGenerator.cs#L178
Possible null reference argument for parameter 'typeName' in 'FacetTargetModel? FlattenToGenerator.FindFacetModel(string typeName, Dictionary<string, FacetTargetModel> facetLookup)'.
test: src/Facet/Generators/FacetGenerators/CodeGenerationHelpers.cs#L192
Dereference of a possibly null reference.
test: src/Facet/Generators/FacetGenerators/AttributeValidator.cs#L52
Possible null reference argument for parameter 'fullyQualifiedMetadataName' in 'INamedTypeSymbol? Compilation.GetTypeByMetadataName(string fullyQualifiedMetadataName)'.
test: src/Facet/Analyzers/SourceSignatureCodeFixProvider.cs#L47
Possible null reference argument for parameter 'newSignature' in 'Task<Document> SourceSignatureCodeFixProvider.UpdateSourceSignatureAsync(Document document, AttributeSyntax attributeSyntax, string newSignature, CancellationToken cancellationToken)'.

Artifacts

Produced during runtime
Name Size Digest
test-results-23804346267 Expired
144 KB
sha256:4e066c3287ab7eec6bd7f40435d511e5c234f781f76358649ac4e51873f3d815