Avoid conflict with other selects when checking for value presence #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The check in line 88 for an <option /> tag with the same value being added can potentially result in a false positive if there is another <select/> element on the page with the same value on an option. Adding the context to the jquery expression seems to fix it.
timschlechter
added a commit
that referenced
this pull request
Oct 5, 2013
Avoid conflict with other selects when checking for value presence
Contributor
|
Thnx for the contribution! |
aivazoff
pushed a commit
to aivazoff/bootstrap-tagsinput
that referenced
this pull request
Apr 19, 2016
Avoid conflict with other selects when checking for value presence
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check in line 88 for an tag with the same value being added can potentially result in a false positive if there is another element on the page with the same value on an option. Adding the context to the jquery expression seems to fix it.