isFinal can be asked outside of $constructor instanceof PhpMethodReflection

ondrejmirtes · ondrejmirtes · commit 85fd1a427618 · 2025-09-10T10:24:22.000+02:00
diff --git a/src/Rules/Classes/NewStaticRule.php b/src/Rules/Classes/NewStaticRule.php
@@ -74,11 +74,11 @@ public function processNode(Node $node, Scope $scope): array
 			}
 		}
 
-		if ($constructor instanceof PhpMethodReflection) {
-			if ($constructor->isFinal()->yes()) {
-				return [];
-			}
+		if ($constructor->isFinal()->yes()) {
+			return [];
+		}
 
+		if ($constructor instanceof PhpMethodReflection) {
 			$prototype = $constructor->getPrototype();
 			if ($prototype->isAbstract()) {
 				return [];

Original file line number	Diff line number	Diff line change
`@@ -74,11 +74,11 @@ public function processNode(Node $node, Scope $scope): array`
`74`	`74`	`}`
`75`	`75`	`}`
`76`	`76`
`77`		`- if ($constructor instanceof PhpMethodReflection) {`
`78`		`- if ($constructor->isFinal()->yes()) {`
`79`		`- return [];`
`80`		`- }`
	`77`	`+ if ($constructor->isFinal()->yes()) {`
	`78`	`+ return [];`
	`79`	`+ }`
`81`	`80`
	`81`	`+ if ($constructor instanceof PhpMethodReflection) {`
`82`	`82`	`$prototype = $constructor->getPrototype();`
`83`	`83`	`if ($prototype->isAbstract()) {`
`84`	`84`	`return [];`