-
Notifications
You must be signed in to change notification settings - Fork 69
Initial versions of Reports API v2 code snippets #82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Alex-Momotov-BA
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code should be made more generic to support different products and product-specific parameters. I left comments where this would cause an issue. It would also be great to test the shell scripts for each product / product-specific parameter combination before merging
|
@Alex-Momotov - thanks for the feedback, you are quite right. I will rethink this and come back with a new set as soon as I can. |
|
@Alex-Momotov I have updated the PR description and included product-specific examples. In the associated main docs I have created tables to show which parameters apply to which calls/products. Each code snippet links to these tables. What I've tried to do is explain that some parameters are call/product-specific, while avoiding complexity in the scripts themselves. |
Description
Initial version of Reports API v2 code snippets.
I have tried to keep the base code snippets as simple as possible. In addition, there are product-specific examples for "load report sync" and "generate report async". Each product has its own subdirectory in these code examples. For example, SMS specific samples can be found in
./reports/sms.These code snippets are meant to be used in conjunction with the associated documentation.
Review