Merge pull request #167 from addwiki/param-encoding

Author: addwiki-ci

RELEASENOTES.md

@@ -4,6 +4,7 @@
 
 - Installatble with PHP 8.1+
 - Fix being unable to set a logger other than Nulllogger in the Guzzle Client [#156](https://github.com/addwiki/addwiki/pull/156)
+- `\Addwiki\Mediawiki\Api\Client\Request\MethodTrait::setMethod()` now normalizes the method to uppercase [#166](https://github.com/addwiki/addwiki/pull/166)
 
 ## Version 3.0 (23 October 2021)
 

src/Client/Request/MethodTrait.php

@@ -11,7 +11,7 @@ public function getMethod(): string {
 	}
 
 	public function setMethod( string $method ): self {
-		$this->method = $method;
+		$this->method = strtoupper( $method );
 		return $this;
 	}
 

tests/unit/Client/Action/Request/FluentRequestTest.php

@@ -62,4 +62,17 @@ public function testSetAction(): void {
 		$this->assertEquals( [ 'action' => 'fooAction' ], $request->getParams() );
 	}
 
+	public function testGetParameterEncoding(): void {
+		$request = ActionRequest::factory();
+
+		$request->setMethod( 'get' );
+		$this->assertSame( 'query', $request->getParameterEncoding() );
+
+		$request->setMethod( 'GET' );
+		$this->assertSame( 'query', $request->getParameterEncoding() );
+
+		$request->setMethod( 'post' );
+		$this->assertSame( 'form_params', $request->getParameterEncoding() );
+	}
+
 }