Skip to content

Transport\BaseTestCase : Improve and Stabilize tests #934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ritoban23 wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Transport\BaseTestCase : Improve and Stabilize tests #934

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9c91c77
Enhance BaseTestCase: Add response object assertions and improve test…
ritoban23 Aug 4, 2025
04804a0
Enhance BaseTestCase: Improve response object assertions and add desc…
ritoban23 Aug 4, 2025
2b20f3b
Enhance BaseTestCase: Improve assertions and add descriptive messages…
ritoban23 Aug 4, 2025
fbc9b3d
Enhance BaseTestCase: Add descriptive messages to assertions for impr…
ritoban23 Aug 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Enhance BaseTestCase: Improve response object assertions and add desc… 
…riptive messages for POST, PUT, PATCH, DELETE, and GET tests
  • Loading branch information
@ritoban23
ritoban23 committed Aug 4, 2025
commit 04804a09e7637b865b3de36f4c0251650d383304
123 changes: 85 additions & 38 deletions tests/Transport/BaseTestCase.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -516,10 +516,13 @@ public static function dataInvalidTypeNotArray() {
public function testFormPost() {
$data = 'test=true&test2=test';
$request = Requests::post($this->httpbin('/post'), [], $data, $this->getOptions());
$this->assertSame(200, $request->status_code);
$this->assertInstanceOf(Response::class, $request, 'POST request should return a Response object');
$this->assertSame(200, $request->status_code, 'POST request should return status code 200');

$result = json_decode($request->body, true);
$this->assertSame(['test' => 'true', 'test2' => 'test'], $result['form']);
$this->assertIsArray($result, 'Response body should be valid JSON array');
$this->assertArrayHasKey('form', $result, 'Response should contain form key');
$this->assertSame(['test' => 'true', 'test2' => 'test'], $result['form'], 'Form data should match expected values');
}

public function testPOSTWithArray() {
Expand All @@ -528,10 +531,13 @@ public function testPOSTWithArray() {
'test2' => 'test',
];
$request = Requests::post($this->httpbin('/post'), [], $data, $this->getOptions());
$this->assertSame(200, $request->status_code);
$this->assertInstanceOf(Response::class, $request, 'POST request should return a Response object');
$this->assertSame(200, $request->status_code, 'POST request should return status code 200');

$result = json_decode($request->body, true);
$this->assertSame(['test' => 'true', 'test2' => 'test'], $result['form']);
$this->assertIsArray($result, 'Response body should be valid JSON array');
$this->assertArrayHasKey('form', $result, 'Response should contain form key');
$this->assertSame(['test' => 'true', 'test2' => 'test'], $result['form'], 'Form data should match expected values');
}

public function testPOSTWithNestedData() {
Expand All @@ -543,28 +549,37 @@ public function testPOSTWithNestedData() {
],
];
$request = Requests::post($this->httpbin('/post'), [], $data, $this->getOptions());
$this->assertSame(200, $request->status_code);
$this->assertInstanceOf(Response::class, $request, 'POST request should return a Response object');
$this->assertSame(200, $request->status_code, 'POST request should return status code 200');

$result = json_decode($request->body, true);
$this->assertSame(['test' => 'true', 'test2[test3]' => 'test', 'test2[test4]' => 'test-too'], $result['form']);
$this->assertIsArray($result, 'Response body should be valid JSON array');
$this->assertArrayHasKey('form', $result, 'Response should contain form key');
$this->assertSame(['test' => 'true', 'test2[test3]' => 'test', 'test2[test4]' => 'test-too'], $result['form'], 'Form data should contain flattened nested data');
}

public function testRawPUT() {
$data = 'test';
$request = Requests::put($this->httpbin('/put'), [], $data, $this->getOptions());
$this->assertSame(200, $request->status_code);
$this->assertInstanceOf(Response::class, $request, 'PUT request should return a Response object');
$this->assertSame(200, $request->status_code, 'PUT request should return status code 200');

$result = json_decode($request->body, true);
$this->assertSame('test', $result['data']);
$this->assertIsArray($result, 'Response body should be valid JSON array');
$this->assertArrayHasKey('data', $result, 'Response should contain data key');
$this->assertSame('test', $result['data'], 'Data should match sent value');
}

public function testFormPUT() {
$data = 'test=true&test2=test';
$request = Requests::put($this->httpbin('/put'), [], $data, $this->getOptions());
$this->assertSame(200, $request->status_code);
$this->assertInstanceOf(Response::class, $request, 'PUT request should return a Response object');
$this->assertSame(200, $request->status_code, 'PUT request should return status code 200');

$result = json_decode($request->body, true);
$this->assertSame(['test' => 'true', 'test2' => 'test'], $result['form']);
$this->assertIsArray($result, 'Response body should be valid JSON array');
$this->assertArrayHasKey('form', $result, 'Response should contain form key');
$this->assertSame(['test' => 'true', 'test2' => 'test'], $result['form'], 'Form data should match expected values');
}

public function testPUTWithArray() {
Expand All @@ -573,28 +588,37 @@ public function testPUTWithArray() {
'test2' => 'test',
];
$request = Requests::put($this->httpbin('/put'), [], $data, $this->getOptions());
$this->assertSame(200, $request->status_code);
$this->assertInstanceOf(Response::class, $request, 'PUT request should return a Response object');
$this->assertSame(200, $request->status_code, 'PUT request should return status code 200');

$result = json_decode($request->body, true);
$this->assertSame(['test' => 'true', 'test2' => 'test'], $result['form']);
$this->assertIsArray($result, 'Response body should be valid JSON array');
$this->assertArrayHasKey('form', $result, 'Response should contain form key');
$this->assertSame(['test' => 'true', 'test2' => 'test'], $result['form'], 'Form data should match expected values');
}

public function testRawPATCH() {
$data = 'test';
$request = Requests::patch($this->httpbin('/patch'), [], $data, $this->getOptions());
$this->assertSame(200, $request->status_code);
$this->assertInstanceOf(Response::class, $request, 'PATCH request should return a Response object');
$this->assertSame(200, $request->status_code, 'PATCH request should return status code 200');

$result = json_decode($request->body, true);
$this->assertSame('test', $result['data']);
$this->assertIsArray($result, 'Response body should be valid JSON array');
$this->assertArrayHasKey('data', $result, 'Response should contain data key');
$this->assertSame('test', $result['data'], 'Data should match sent value');
}

public function testFormPATCH() {
$data = 'test=true&test2=test';
$request = Requests::patch($this->httpbin('/patch'), [], $data, $this->getOptions());
$this->assertSame(200, $request->status_code, $request->body);
$this->assertInstanceOf(Response::class, $request, 'PATCH request should return a Response object');
$this->assertSame(200, $request->status_code, 'PATCH request should return status code 200');

$result = json_decode($request->body, true);
$this->assertSame(['test' => 'true', 'test2' => 'test'], $result['form']);
$this->assertIsArray($result, 'Response body should be valid JSON array');
$this->assertArrayHasKey('form', $result, 'Response should contain form key');
$this->assertSame(['test' => 'true', 'test2' => 'test'], $result['form'], 'Form data should match expected values');
}

public function testPATCHWithArray() {
Expand All @@ -603,24 +627,32 @@ public function testPATCHWithArray() {
'test2' => 'test',
];
$request = Requests::patch($this->httpbin('/patch'), [], $data, $this->getOptions());
$this->assertSame(200, $request->status_code);
$this->assertInstanceOf(Response::class, $request, 'PATCH request should return a Response object');
$this->assertSame(200, $request->status_code, 'PATCH request should return status code 200');

$result = json_decode($request->body, true);
$this->assertSame(['test' => 'true', 'test2' => 'test'], $result['form']);
$this->assertIsArray($result, 'Response body should be valid JSON array');
$this->assertArrayHasKey('form', $result, 'Response should contain form key');
$this->assertSame(['test' => 'true', 'test2' => 'test'], $result['form'], 'Form data should match expected values');
}

public function testOPTIONS() {
$request = Requests::options($this->httpbin('/options'), [], [], $this->getOptions());
$this->assertSame(200, $request->status_code);
$this->assertInstanceOf(Response::class, $request, 'OPTIONS request should return a Response object');
$this->assertSame(200, $request->status_code, 'OPTIONS request should return status code 200');
}

public function testDELETE() {
$request = Requests::delete($this->httpbin('/delete'), [], $this->getOptions());
$this->assertSame(200, $request->status_code);
$this->assertInstanceOf(Response::class, $request, 'DELETE request should return a Response object');
$this->assertSame(200, $request->status_code, 'DELETE request should return status code 200');

$result = json_decode($request->body, true);
$this->assertSame($this->httpbin('/delete'), $result['url']);
$this->assertEmpty($result['args']);
$this->assertIsArray($result, 'Response body should be valid JSON array');
$this->assertArrayHasKey('url', $result, 'Response should contain url key');
$this->assertSame($this->httpbin('/delete'), $result['url'], 'Response URL should match request URL');
$this->assertArrayHasKey('args', $result, 'Response should contain args key');
$this->assertEmpty($result['args'], 'Args should be empty for DELETE request');
}

public function testDELETEWithData() {
Expand All @@ -629,16 +661,21 @@ public function testDELETEWithData() {
'test2' => 'test',
];
$request = Requests::request($this->httpbin('/delete'), [], $data, Requests::DELETE, $this->getOptions());
$this->assertSame(200, $request->status_code);
$this->assertInstanceOf(Response::class, $request, 'DELETE request should return a Response object');
$this->assertSame(200, $request->status_code, 'DELETE request should return status code 200');

$result = json_decode($request->body, true);
$this->assertSame($this->httpbin('/delete?test=true&test2=test'), $result['url']);
$this->assertSame(['test' => 'true', 'test2' => 'test'], $result['args']);
$this->assertIsArray($result, 'Response body should be valid JSON array');
$this->assertArrayHasKey('url', $result, 'Response should contain url key');
$this->assertSame($this->httpbin('/delete?test=true&test2=test'), $result['url'], 'Response URL should match expected URL with data');
$this->assertArrayHasKey('args', $result, 'Response should contain args key');
$this->assertSame(['test' => 'true', 'test2' => 'test'], $result['args'], 'Args should contain expected data');
}

public function testLOCK() {
$request = Requests::request($this->httpbin('/lock'), [], [], 'LOCK', $this->getOptions());
$this->assertSame(200, $request->status_code);
$this->assertInstanceOf(Response::class, $request, 'LOCK request should return a Response object');
$this->assertSame(200, $request->status_code, 'LOCK request should return status code 200');
}

public function testLOCKWithData() {
Expand All @@ -647,24 +684,29 @@ public function testLOCKWithData() {
'test2' => 'test',
];
$request = Requests::request($this->httpbin('/lock'), [], $data, 'LOCK', $this->getOptions());
$this->assertSame(200, $request->status_code);
$this->assertInstanceOf(Response::class, $request, 'LOCK request should return a Response object');
$this->assertSame(200, $request->status_code, 'LOCK request should return status code 200');

$result = json_decode($request->body, true);
$this->assertSame(['test' => 'true', 'test2' => 'test'], $result['form']);
$this->assertIsArray($result, 'Response body should be valid JSON array');
$this->assertArrayHasKey('form', $result, 'Response should contain form key');
$this->assertSame(['test' => 'true', 'test2' => 'test'], $result['form'], 'Form data should match expected values');
}

public function testRedirects() {
$request = Requests::get($this->httpbin('/redirect/6'), [], $this->getOptions());
$this->assertSame(200, $request->status_code);
$this->assertInstanceOf(Response::class, $request, 'GET request should return a Response object');
$this->assertSame(200, $request->status_code, 'Final redirect should return status code 200');

$this->assertSame(6, $request->redirects);
$this->assertSame(6, $request->redirects, 'Should have followed exactly 6 redirects');
}

public function testRelativeRedirects() {
$request = Requests::get($this->httpbin('/relative-redirect/6'), [], $this->getOptions());
$this->assertSame(200, $request->status_code);
$this->assertInstanceOf(Response::class, $request, 'GET request should return a Response object');
$this->assertSame(200, $request->status_code, 'Final relative redirect should return status code 200');

$this->assertSame(6, $request->redirects);
$this->assertSame(6, $request->redirects, 'Should have followed exactly 6 relative redirects');
}

public function testTooManyRedirects() {
Expand Down Expand Up @@ -739,8 +781,9 @@ public function testStatusCode($code, $success) {
'transport' => $transport,
];
$request = Requests::get($url, [], $options);
$this->assertSame($code, $request->status_code);
$this->assertSame($success, $request->success);
$this->assertInstanceOf(Response::class, $request, 'Request should return a Response object');
$this->assertSame($code, $request->status_code, sprintf('Status code should be %d', $code));
$this->assertSame($success, $request->success, sprintf('Success property should be %s for status code %d', $success ? 'true' : 'false', $code));
}

/**
Expand Down Expand Up @@ -808,8 +851,9 @@ public function testStatusCodeUnknown() {
];

$request = Requests::get($this->httpbin('/status/599'), [], $options);
$this->assertSame(599, $request->status_code);
$this->assertFalse($request->success);
$this->assertInstanceOf(Response::class, $request, 'Request should return a Response object');
$this->assertSame(599, $request->status_code, 'Status code should be 599');
$this->assertFalse($request->success, 'Success property should be false for unknown status code');
}

public function testStatusCodeThrowUnknown() {
Expand All @@ -828,10 +872,13 @@ public function testStatusCodeThrowUnknown() {

public function testGzipped() {
$request = Requests::get($this->httpbin('/gzip'), [], $this->getOptions());
$this->assertSame(200, $request->status_code);
$this->assertInstanceOf(Response::class, $request, 'GET request should return a Response object');
$this->assertSame(200, $request->status_code, 'Gzipped request should return status code 200');

$result = json_decode($request->body);
$this->assertTrue($result->gzipped);
$this->assertIsObject($result, 'Response body should be valid JSON object');
$this->assertObjectHasProperty('gzipped', $result, 'Response should contain gzipped property');
$this->assertTrue($result->gzipped, 'Response should indicate content was gzipped');
}

public function testStreamToFile() {
Expand Down