Skip to content

Commit 41235ee

Browse files
youknowriadsarayourfriend
authored andcommitted
Prevent entering invalid values in the Query Loop block config (#33285)
1 parent 25256a0 commit 41235ee

File tree

1 file changed

+27
-10
lines changed

1 file changed

+27
-10
lines changed

packages/block-library/src/query/edit/query-toolbar.js

Lines changed: 27 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -61,11 +61,18 @@ export default function QueryToolbar( {
6161
labelPosition="edge"
6262
min={ 1 }
6363
max={ 100 }
64-
onChange={ ( value ) =>
64+
onChange={ ( value ) => {
65+
if (
66+
isNaN( value ) ||
67+
value < 1 ||
68+
value > 100
69+
) {
70+
return;
71+
}
6572
setQuery( {
66-
perPage: +value ?? -1,
67-
} )
68-
}
73+
perPage: value,
74+
} );
75+
} }
6976
step="1"
7077
value={ query.perPage }
7178
isDragEnabled={ false }
@@ -78,9 +85,16 @@ export default function QueryToolbar( {
7885
labelPosition="edge"
7986
min={ 0 }
8087
max={ 100 }
81-
onChange={ ( value ) =>
82-
setQuery( { offset: +value } )
83-
}
88+
onChange={ ( value ) => {
89+
if (
90+
isNaN( value ) ||
91+
value < 0 ||
92+
value > 100
93+
) {
94+
return;
95+
}
96+
setQuery( { offset: value } );
97+
} }
8498
step="1"
8599
value={ query.offset }
86100
isDragEnabled={ false }
@@ -98,9 +112,12 @@ export default function QueryToolbar( {
98112
label={ __( 'Max page to show' ) }
99113
labelPosition="edge"
100114
min={ 0 }
101-
onChange={ ( value ) =>
102-
setQuery( { pages: +value } )
103-
}
115+
onChange={ ( value ) => {
116+
if ( isNaN( value ) || value < 0 ) {
117+
return;
118+
}
119+
setQuery( { pages: value } );
120+
} }
104121
step="1"
105122
value={ query.pages }
106123
isDragEnabled={ false }

0 commit comments

Comments
 (0)