From a511b9577356a79c1f1330c33934eab54604a694 Mon Sep 17 00:00:00 2001 From: "Joen A." <1204802+jasmussen@users.noreply.github.com> Date: Tue, 16 Jul 2024 13:19:55 +0200 Subject: [PATCH 01/19] Icons: Update close icon. (#63597) Co-authored-by: jasmussen Co-authored-by: jameskoster --- packages/block-library/src/image/index.php | 2 +- packages/block-library/src/navigation/index.php | 2 +- .../components/src/notice/test/__snapshots__/index.tsx.snap | 2 +- packages/icons/src/library/close.js | 2 +- .../nux/src/components/dot-tip/test/__snapshots__/index.js.snap | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/packages/block-library/src/image/index.php b/packages/block-library/src/image/index.php index 886843d83ba720..ace6a365469012 100644 --- a/packages/block-library/src/image/index.php +++ b/packages/block-library/src/image/index.php @@ -303,7 +303,7 @@ class="wp-lightbox-overlay zoom" tabindex="-1" >
diff --git a/packages/block-library/src/navigation/index.php b/packages/block-library/src/navigation/index.php index 99feef98542ed9..a73aa682f596c9 100644 --- a/packages/block-library/src/navigation/index.php +++ b/packages/block-library/src/navigation/index.php @@ -483,7 +483,7 @@ private static function get_responsive_container_markup( $attributes, $inner_blo } } $toggle_button_content = $should_display_icon_label ? $toggle_button_icon : __( 'Menu' ); - $toggle_close_button_icon = ''; + $toggle_close_button_icon = ''; $toggle_close_button_content = $should_display_icon_label ? $toggle_close_button_icon : __( 'Close' ); $toggle_aria_label_open = $should_display_icon_label ? 'aria-label="' . __( 'Open menu' ) . '"' : ''; // Open button label. $toggle_aria_label_close = $should_display_icon_label ? 'aria-label="' . __( 'Close menu' ) . '"' : ''; // Close button label. diff --git a/packages/components/src/notice/test/__snapshots__/index.tsx.snap b/packages/components/src/notice/test/__snapshots__/index.tsx.snap index a793b5db706a4c..c74d6fdd0a6fc9 100644 --- a/packages/components/src/notice/test/__snapshots__/index.tsx.snap +++ b/packages/components/src/notice/test/__snapshots__/index.tsx.snap @@ -54,7 +54,7 @@ exports[`Notice should match snapshot 1`] = ` xmlns="http://www.w3.org/2000/svg" > diff --git a/packages/icons/src/library/close.js b/packages/icons/src/library/close.js index 35f0f9bfc71e6e..080a8826f8f8bb 100644 --- a/packages/icons/src/library/close.js +++ b/packages/icons/src/library/close.js @@ -5,7 +5,7 @@ import { SVG, Path } from '@wordpress/primitives'; const close = ( - + ); diff --git a/packages/nux/src/components/dot-tip/test/__snapshots__/index.js.snap b/packages/nux/src/components/dot-tip/test/__snapshots__/index.js.snap index 2fefa70d5b0a2c..dbea46e35fb091 100644 --- a/packages/nux/src/components/dot-tip/test/__snapshots__/index.js.snap +++ b/packages/nux/src/components/dot-tip/test/__snapshots__/index.js.snap @@ -39,7 +39,7 @@ exports[`DotTip should render correctly 1`] = ` xmlns="http://www.w3.org/2000/svg" > From b0f2fb97ac632ec5716852e8bab7be169fa32a40 Mon Sep 17 00:00:00 2001 From: James Koster Date: Tue, 16 Jul 2024 12:23:10 +0100 Subject: [PATCH 02/19] Increase column-gap between fields (#63603) Co-authored-by: jameskoster Co-authored-by: jasmussen --- packages/dataviews/src/style.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/dataviews/src/style.scss b/packages/dataviews/src/style.scss index 46b4b09d317ce8..ce0e4c812ff03a 100644 --- a/packages/dataviews/src/style.scss +++ b/packages/dataviews/src/style.scss @@ -579,7 +579,7 @@ .dataviews-view-list__fields { color: $gray-700; display: flex; - gap: $grid-unit-10; + gap: $grid-unit-15; row-gap: $grid-unit-05; flex-wrap: wrap; font-size: 12px; From abdc991671e980d5e2c44e859ad202d64a35c060 Mon Sep 17 00:00:00 2001 From: James Koster Date: Tue, 16 Jul 2024 12:37:36 +0100 Subject: [PATCH 03/19] Reduce navigation sidebar width (#63431) Co-authored-by: jameskoster Co-authored-by: jasmussen Co-authored-by: richtabor --- packages/base-styles/_variables.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/base-styles/_variables.scss b/packages/base-styles/_variables.scss index 0638911b94321e..dfbc1e15ac2ffc 100644 --- a/packages/base-styles/_variables.scss +++ b/packages/base-styles/_variables.scss @@ -51,7 +51,7 @@ $button-size-small: 24px; $button-size-compact: 32px; $header-height: 60px; $panel-header-height: $grid-unit-60; -$nav-sidebar-width: 360px; +$nav-sidebar-width: 300px; $admin-bar-height: 32px; $admin-bar-height-big: 46px; $admin-sidebar-width: 160px; From 2171d824a4f75c66c748db02cf3152c4487ba93a Mon Sep 17 00:00:00 2001 From: Marco Ciampini Date: Tue, 16 Jul 2024 14:20:00 +0200 Subject: [PATCH 04/19] ToggleGroupControl: support `disabled` options (#63450) * Add disabled option tests * Fix handling of disabled prop on ToggleGroupControl options * Add basic disabled styles * Update snapshots * CHANGELOG * Support accessibleWhenDisabled for ratio option items * Support accessibleWhenDisabled for button option items * Update snapshots * Update tests to reflect that options are keyboard focusable while disabled * Move CHANGELOG entry to enhancements section * Revert "Support accessibleWhenDisabled for ratio option items" This reverts commit 62959f041a499b9c63291b0c790474da0b494a5b. --- Co-authored-by: ciampo Co-authored-by: mirka <0mirka00@git.wordpress.org> Co-authored-by: tyxla Co-authored-by: stokesman Co-authored-by: jasmussen --- packages/components/CHANGELOG.md | 1 + .../test/__snapshots__/index.tsx.snap | 42 ++++++- .../src/toggle-group-control/test/index.tsx | 114 ++++++++++++++++++ .../component.tsx | 7 +- .../styles.ts | 5 + 5 files changed, 162 insertions(+), 7 deletions(-) diff --git a/packages/components/CHANGELOG.md b/packages/components/CHANGELOG.md index aa72d126dfb69d..3a6ce15c62a7a9 100644 --- a/packages/components/CHANGELOG.md +++ b/packages/components/CHANGELOG.md @@ -21,6 +21,7 @@ ### Enhancements +- `ToggleGroupControl`: support disabled options ([#63450](https://github.com/WordPress/gutenberg/pull/63450)). - `CustomSelectControl`: Stabilize `__experimentalShowSelectedHint` and `options[]. __experimentalHint` props ([#63248](https://github.com/WordPress/gutenberg/pull/63248)). ## 28.3.0 (2024-07-10) diff --git a/packages/components/src/toggle-group-control/test/__snapshots__/index.tsx.snap b/packages/components/src/toggle-group-control/test/__snapshots__/index.tsx.snap index a7adcc81aa7359..cdfa4b1883cc16 100644 --- a/packages/components/src/toggle-group-control/test/__snapshots__/index.tsx.snap +++ b/packages/components/src/toggle-group-control/test/__snapshots__/index.tsx.snap @@ -132,6 +132,11 @@ exports[`ToggleGroupControl controlled should render correctly with icons 1`] = border: 0; } +.emotion-12[disabled] { + opacity: 0.4; + cursor: default; +} + .emotion-12:active { background: #fff; } @@ -213,6 +218,11 @@ exports[`ToggleGroupControl controlled should render correctly with icons 1`] = border: 0; } +.emotion-18[disabled] { + opacity: 0.4; + cursor: default; +} + .emotion-18:active { background: #fff; } @@ -238,7 +248,7 @@ exports[`ToggleGroupControl controlled should render correctly with icons 1`] = class="components-toggle-group-control emotion-8 emotion-9" data-wp-c16t="true" data-wp-component="ToggleGroupControl" - id="toggle-group-control-as-radio-group-10" + id="toggle-group-control-as-radio-group-11" role="radiogroup" >